search

rancher-sandbox / rancher-desktop

Container Management and Kubernetes on the Desktop
https://rancherdesktop.io
Apache License 2.0
5.82k stars 272 forks source link

Rename `Allow sudo access` to `Make global changes to system (requires sudo access)` #2381

Open jsoref opened 2 years ago

jsoref commented 2 years ago

Actual Behavior

Allow sudo access is a checkmark that really doesn't mean anything to mac or Windows users.

Steps to Reproduce

  1. Install or upgrade to Rancher Desktop 1.4.1
  2. Open Rancher Desktop
  3. You may see: image
  4. Note that sudo is not mentioned in the highlights of this screen -- but administrative is. (sudo access is a parenthetical)
  5. For fun, click the expando: image
  6. Note that this causes the dialog to become wider (for no particularly good reason, it could have had that width from the beginning) and taller (this isn't unreasonable, it's showing more rows of content).
  7. Click OK
  8. Get a dialog which doesn't mention sudo: image
  9. Hopefully you don't accidentally cancel it because of focus issues while trying to file this ticket
  10. Go to Application Settings image
  11. Hover over Administrative Access ℹ️ to try to figure out what the thing means† image

†Note that the current information item is not reachable using Voice Over

Result

As a user who is familiar w/ macOS or Windows, the Application Settings page's explanation of what Administrative Access is for is really unhelpful. As a screen reader user, it's outright hostile.

Expected Behavior

User meaningful words Make global changes to system or something to at least hint at what's going on.

Additional Information

Tangentially related to #2178

https://user-images.githubusercontent.com/2119212/173406689-75d94ef6-c6c9-4389-bf36-3f5f25bdca34.mov

Rancher Desktop Version

1.4.1

Rancher Desktop K8s Version

(Off)

Which container runtime are you using?

moby (docker cli)

What operating system are you using?

macOS

Operating System / Build Version

Monterey 12.4

What CPU architecture are you using?

arm64 (Apple Silicon)

Linux only: what package format did you use to install Rancher Desktop?

No response

Windows User Only

No response

jandubois commented 2 years ago

User meaningful words Make global changes to system or something to at least hint at what's going on.

Sorry, but "Make global changes to system" are also not meaningful to me. The dialog should explain explicitly what they allow, and why, which is why I filed #2178, even though the discussion there is more about the docker context subset of issues.

The accessibility problem is really separate and should have it's own Github issue. I wonder if that problem is limited to this dialog, or more pervasive?

jsoref commented 2 years ago

The dialog is unhelpful because most of the time the user doesn't see the dialog. I shouldn't have seen the dialog, as afaik, this wasn't an update or install launch.

This issue is only about a checkbox, which really has no reachable context to explain what it's doing.

The way I naively understand the checkbox, it means that if a different user uses this computer, they too could have access to the rancher-desktop I'm running, whereas w/o this checkbox, they couldn't. Am I wrong? That's my definition of global -- the question is "what user visible effect does the box have?"

It's pervasive, and I'll file it, I just needed a place to hang the video because I didn't have the energy to grab the frame.

jsoref commented 2 years ago

Fwiw, I filed my initial accessibility survey as #2383