search

rancher-sandbox / rancher-desktop

Container Management and Kubernetes on the Desktop
https://rancherdesktop.io
Apache License 2.0
5.71k stars 267 forks source link

Filesystem user mapping different than Docker Desktop #2514

Open jsedano-emobg opened 1 year ago

jsedano-emobg commented 1 year ago

Actual Behavior

When using the VSCode remote-container plugin to open a project in-container, the files are owned by the external user instead of root. That is: file owning is not mapped from outside to inside.

I am creating this as a bug because in Docker Desktop for Mac the filesystem user is mapped from the local user to root, but in Rancher Desktop for Mac, it is not; since I understand we want to mimic this kind of behaviours from DD, I think it may be a bug

Also, it MAY be a bug in VSCode remote-container extension, but since it works on Docker Desktop, looks like the problem is in Rancher Desktop.

Steps to Reproduce

I have created a simple test repository reproducing the error at https://gitlab.com/javier-sedano/user-map/-/tree/master

  1. Clone the repo
  2. Install VSCode (I am using 1.69.0 for Mac) and "remote - containers" (I am using 0.241.3)
  3. Open the cloned folder in VSCode
  4. It will offer to "Reopen in container"; do it

Result

I see the following in a VSCode terminal:

root@61970ae95f98:/app# ls -lan
total 16
drwxr-xr-x 1 502 20  160 Jul 11 10:09 .
drwxr-xr-x 1   0  0 4096 Jul 11 10:07 ..
drwxr-xr-x 1 502 20  192 Jul 11 10:09 .devcontainer
drwxr-xr-x 1 502 20  384 Jul 11 10:10 .git
-rw-r--r-- 1 502 20    0 Jul 11 10:09 README.md
root@61970ae95f98:/app# git checkout
fatal: unsafe repository ('/app' is owned by someone else)
To add an exception for this directory, call:

        git config --global --add safe.directory /app
root@61970ae95f98:/app#

Notice how files are owned by 502, which is my user in the host (my Mac).

This causes modern git to fail (causing the git view of VSCode to fail), for example, but other things fail as well.

My files in the host, outside the container:

javier.sedano@MacBook-Pro-de-admeis user-map % ls -lan
total 0
drwxr-xr-x   5 502  20  160 Jul 11 12:09 .
drwxr-xr-x  10 502  20  320 Jul 11 12:09 ..
drwxr-xr-x   6 502  20  192 Jul 11 12:09 .devcontainer
drwxr-xr-x  12 502  20  384 Jul 11 12:10 .git
-rw-r--r--   1 502  20    0 Jul 11 12:09 README.md
javier.sedano@MacBook-Pro-de-admeis user-map %

Expected Behavior

When using Docker Dektop for Mac, and following the same procedure, the following is shown in the terminal:

root@0036fc4efb35:/app# ls -lan
total 4
drwxr-xr-x  5 0 0  160 Jul 11 10:20 .
drwxr-xr-x  1 0 0 4096 Jul 11 10:21 ..
drwxr-xr-x  6 0 0  192 Jul 11 10:20 .devcontainer
drwxr-xr-x 12 0 0  384 Jul 11 10:20 .git
-rw-r--r--  1 0 0    0 Jul 11 10:20 README.md
root@0036fc4efb35:/app# git checkout
Your branch is up to date with 'origin/master'.
root@0036fc4efb35:/app#

And outside the container:

➜ user-map git:(master) ls -lan
total 0
drwxr-xr-x  [5 1425016936](tel:51425016936) 686672032 160 11 jul 12:20 .
drwxr-xr-x  [7 1425016936](tel:71425016936) 686672032 224 11 jul 12:20 ..
drwxr-xr-x  [6 1425016936](tel:61425016936) 686672032 192 11 jul 12:20 .devcontainer
drwxr-xr-x [12 1425016936](tel:121425016936) 686672032 384 11 jul 12:22 .git
-rw-r--r--  [1 1425016936](tel:11425016936) 686672032  0 11 jul 12:20 README.md

Additional Information

No response

Rancher Desktop Version

1.4.1

Rancher Desktop K8s Version

Disabled (1.22.7)

Which container runtime are you using?

moby (docker cli)

What operating system are you using?

macOS

Operating System / Build Version

12.3.1 Monterey

What CPU architecture are you using?

arm64 (Apple Silicon)

Linux only: what package format did you use to install Rancher Desktop?

No response

Windows User Only

No response

jsedano-emobg commented 1 year ago

Anybody any news about this topic?

jsedanoj commented 1 year ago

I have upgraded to Rancher Desktop 1.5.1 and VSCode 1.71.1 with "remote - containers" 0.251.0and nothing has changed, the problem is still there.

jandubois commented 1 year ago

Anybody any news about this topic?

Sorry, there is no news yet; we haven't gotten around to looking into this issue yet.

jsedanoj commented 1 year ago

I have simplified the test case, definitely it has nothing to do with VSCode.

When I run this command using Docker Desktop for Mac (M1), using the straightforward Next-Next-Next setup, I get:

javier.sedano@MacBook-Pro-de-admeis test-user-map % docker run -v /Users/javier.sedano/tmp/test-user-map/test-dir/:/test-dir --rm -ti alpine ls -lan /test-dir
total 4
drwxr-xr-x    3 0        0               96 Sep 16 09:57 .
drwxr-xr-x    1 0        0             4096 Sep 18 09:50 ..
-rw-r--r--    1 0        0                0 Sep 16 09:57 hello.txt
javier.sedano@MacBook-Pro-de-admeis test-user-map %

When I run the same command in Rancher Desktop for Mac (M1) 1.5.1, using dockerd/moby (docker cli), I get:

javier.sedano@MacBook-Pro-de-admeis test-user-map % docker run -v /Users/javier.sedano/tmp/test-user-map/test-dir/:/test-dir --rm -ti alpine ls -lan /test-dir
total 8
drwxr-xr-x    1 502      20              96 Sep 16 09:57 .
drwxr-xr-x    1 0        0             4096 Sep 18 09:58 ..
-rw-r--r--    1 502      20               0 Sep 16 09:57 hello.txt
javier.sedano@MacBook-Pro-de-admeis test-user-map %

Switching to containerd (nerdtcl cli) does not change the result:

javier.sedano@MacBook-Pro-de-admeis test-user-map % nerdctl run -v /Users/javier.sedano/tmp/test-user-map/test-dir/:/test-dir --rm -ti alpine ls -lan /test-dir
total 8
drwxr-xr-x    1 502      20              96 Sep 16 09:57 .
drwxr-xr-x    1 0        0             4096 Sep 18 10:00 ..
-rw-r--r--    1 502      20               0 Sep 16 09:57 hello.txt
javier.sedano@MacBook-Pro-de-admeis test-user-map %

What is surprising to me is... this looks like a pretty straightforward run... I can't believe I am the first person finding the issue...

jsedano-emobg commented 1 year ago

After updating to Rancher Desktop 1.6.0, still no change.

jsedano-emobg commented 1 year ago

Updated to 1.7.0 still no change.

Is anybody tracking the bug?

jsedano-emobg commented 1 year ago

I have upgraded to 1.8.1, it still fails.

jsedanoj commented 11 months ago

Upgraded to 1.9.1... it still fails

jsedano-emobg commented 8 months ago

I Tested 1.10.1... no change.

I bet nobody is working on it. I see @jandubois has tagged with "need-to-repro"... Do you want us to have a meeting so I show you the failure?

jandubois commented 8 months ago

I see @jandubois has tagged with "need-to-repro"... Do you want us to have a meeting so I show you the failure?

The label means it is in the queue for somebody from the team to reproduce it locally (and ideally write a BATS test for it), but you are correct, in that nobody has worked on it yet. Once we repro it, it will be put into the backlog. If we can't repro it, we'll be asking more questions here.

Sorry for the long delay, it is definitely something I would like to see addressed, but we didn't have somebody available to repro/analyze it yet. 😞

jsedano-emobg commented 6 months ago

Tested 1.11.1, no difference.

jsedano-emobg commented 3 months ago

Tested 1.13.1, no change, it still fails.

jsedano-emobg commented 1 week ago

Tested with 1.14.2, no change, it still fails.