search

rancher-sandbox / rancher-desktop

Container Management and Kubernetes on the Desktop
https://rancherdesktop.io
Apache License 2.0
5.93k stars 280 forks source link

Add support for vzNAT networking #5176

Open jandubois opened 1 year ago

jandubois commented 1 year ago

vde_vmnet and socket_vmnet do not work with VZ emulation mode. The goal is to support user-v2 networking, but since that has not yet landed in Lima we should support vzNAT in the interim.

AkihiroSuda commented 1 year ago

vde_vmnet and socket_vmnet do not work with VZ emulation mode.

Why? At least socket_vmnet is expected to work.

The goal is to support user-v2 networking, but since that has not yet landed in Lima we should support vzNAT in the interim.

user-v2 has landed in Lima v0.16.0, but it seems an off-topic here, as it does not support host-to-VM IP reachability.

jandubois commented 1 year ago

At least socket_vmnet is expected to work.

It is? I'll double-check; I thought it didn't.

AkihiroSuda commented 1 year ago

At least socket_vmnet is expected to work.

It is? I'll double-check; I thought it didn't.

Yes

AkihiroSuda commented 1 year ago

(Anyway, vzNAT is better than socket_vmnet as it doesn't require sudo. vzNAT doesn't support VM-to-VM networking but it doesn't seem to be a problem for Rancher Desktop.)

jandubois commented 1 year ago

It is? I'll double-check; I thought it didn't.

It looks like vde_vmnet doesn't work, and I just assumed that socket_vmnet would then also not work, as the 2 are identical from an API perspective. It looks I disabled both for the 1.9.0 release: https://github.com/rancher-sandbox/rancher-desktop/commit/18d94918caf920dc74455a194268684ce5700c18.

I guess I can re-enable socket_vmnet and leave vzNAT support for 1.11 then.

rsmogura commented 1 year ago

Hi all. Sorry for jumping out of the blue this is my first pull request here.

Looking for feedback.