jandubois
commented
8 months ago We have a
RD_USE_GHCR_IMAGESoption for BATS; however, therancher/rancherimage is always pulled from Docker Hub instead of GHCR.
One problem is that we make the tag configurable via RD_RANCHER_IMAGE_TAG, so if the image would be subject to RD_USE_GHCR_IMAGES, then all the tags would have to be mirrored, and we would have to update the mirror on each minor Rancher release.
It is also less important to pull this specific image from ghcr.io because images from the rancher org on Dockerhub are not currently subject to the image pull quota, due to a business agreement between SUSE and Docker.
Actual Behavior
We have a
RD_USE_GHCR_IMAGESoption for BATS; however, therancher/rancherimage is always pulled from Docker Hub instead of GHCR.Steps to Reproduce
By code inspection: https://github.com/rancher-sandbox/rancher-desktop/blob/c2a201b7d12f80a1eddc8292e8e0e898ab1605ef/bats/tests/containers/run-rancher.bats#L13 https://github.com/rancher-sandbox/rancher-desktop/blob/c2a201b7d12f80a1eddc8292e8e0e898ab1605ef/bats/tests/helpers/images.bash#L11
Result
The image is not mirrored.
(I thought this was causing a failure in CI, but it turns out it was because the allowed images list was enabled, so that's a red herring.)
Expected Behavior
The image is mirrored.
Additional Information
I tried to push to the mirror but it didn't like my token.
Rancher Desktop Version
1.12+ (c2a201b7d12f80a1eddc8292e8e0e898ab1605ef)
Rancher Desktop K8s Version
N/A
Which container engine are you using?
containerd (nerdctl)
What operating system are you using?
macOS
Operating System / Build Version
macOS Ventura 13.6.3
What CPU architecture are you using?
arm64 (Apple Silicon)
Linux only: what package format did you use to install Rancher Desktop?
None
Windows User Only
No response