search

rancher-sandbox / rancher-desktop

Container Management and Kubernetes on the Desktop
https://rancherdesktop.io
Apache License 2.0
6.01k stars 282 forks source link

rdctl: Hidden settings show as not available on platform #7226

Open mook-as opened 3 months ago

mook-as commented 3 months ago

Actual Behavior

When a setting is set to x-rd-hidden: true, we report is as not being available on the current platform instead of just unavailable, which is incorrect.

rdctl set --application.extensions.allowed.enabled=false
Error: option --application.extensions.allowed.enabled is not available on Windows

Steps to Reproduce

rdctl set --application.extensions.allowed.enabled=false

(That setting is already x-rd-hidden)

Result

Error: option --application.extensions.allowed.enabled is not available on Windows

Expected Behavior

Error: option --application.extensions.allowed.enabled is not available

Alternatively, act as if the setting does not exist.

Additional Information

No response

Rancher Desktop Version

0c984fe5257f39ea41633d0bddf841ed5919e1af

Rancher Desktop K8s Version

N/A

Which container engine are you using?

containerd (nerdctl)

What operating system are you using?

Windows

Operating System / Build Version

Windows 10 22H2 Build 19045.4651

What CPU architecture are you using?

x64

Linux only: what package format did you use to install Rancher Desktop?

None

Windows User Only

No response

jandubois commented 3 months ago

x-rd-hidden was implemented in RDX: Add preferences for extension allow list

It throws the same error on all platforms, so not quite sure what the point of adding a hidden setting is.

Maybe we need to get rid of this setting instead of fixing it?