search

rancher-sandbox / rancher-desktop

Container Management and Kubernetes on the Desktop
https://rancherdesktop.io
Apache License 2.0
6.03k stars 285 forks source link

Remove Listener Creation for Containerd Events #7781

Closed Nino-K closed 6 days ago

Nino-K commented 6 days ago

Historically, when containerd events were received, we created listeners to leverage the WSL listener forwarding feature. This was necessary because containerd, unlike Docker, didn't create listeners for running containers. Instead, it routed traffic through iptables rules in the CNI-HOSTPORT-DNAT chain, manipulating container traffic directly.

However, with the new namespaced network configuration, the WSL listener forwarding feature is no longer in use. As a result, we no longer need to manually create listeners for each running container.

Fixes: https://github.com/rancher-sandbox/rancher-desktop/issues/7782

Nino-K commented 6 days ago

Do we still need ListenerTracker (and its associated tests) at all? That looks unused now.

I was going to repurpose that for the proc/net/ scanning PR would you like me to remove and re-add later?

mook-as commented 6 days ago

Do we still need ListenerTracker (and its associated tests) at all? That looks unused now.

I was going to repurpose that for the proc/net/ scanning PR would you like me to remove and re-add later?

Nah, we can keep it as-is then.