search

rancher / aks-operator

Azure Kubernetes Service operator for Rancher
Apache License 2.0
9 stars 29 forks source link

Log is misleading when updating tags #582

Closed valaparthvi closed 2 months ago

valaparthvi commented 4 months ago

Rancher version: v2.9-d2fa8a7d6116c48a814ee7983af522d614461e49-head Operator version: rancher/aks-operator:v1.9.0-rc.9

When new tags are added, in this case foo:bar and fun:two, the following logs appear:

"Checking configuration for cluster [pvala-aks]"
time="2024-07-08T06:36:55Z" level=info msg="Updating tags for cluster [pvala-aks]"
time="2024-07-08T06:37:03Z" level=info msg="Tags were not updated for cluster [pvala-aks], config map[Account Owner:mlatimer@suse.com Account Type:group Cost Center:211799999 Department:ecm Environment:development Finance Business Partner:geoff.guest@suse.com General Ledger Code:200000119 Stakeholder:jeff.hobbs@suse.com Team:enterprise-storage foo:bar fun:two], upstream map[Account Owner:mlatimer@suse.com Account Type:group Cost Center:211799999 Department:ecm Environment:development Finance Business Partner:geoff.guest@suse.com General Ledger Code:200000119 Stakeholder:jeff.hobbs@suse.com Team:enterprise-storage foo:bar fun:two], moving on"
time="2024-07-08T06:37:03Z" level=info msg="Configuration for cluster [pvala-aks] was verified"

Tags were not updated for cluster is somewhat misleading even though the tags are updated successfully.

cpinjani commented 4 months ago

See also: https://github.com/rancher/aks-operator/issues/508

mjura commented 2 months ago

it is duplication of #508 it was already fixed in: