search

rancher / aks-operator

Azure Kubernetes Service operator for Rancher
Apache License 2.0
9 stars 29 forks source link

Unable to remove an authorized IP range #592

Closed valaparthvi closed 4 weeks ago

valaparthvi commented 1 month ago

Rancher: v2.9-3c4ccdc5bc9fde3510089153b5ad58fdbe604880-head Dashboard: master https://github.com/rancher/dashboard/commit/00e9eb2a64b5bde237fd9b9e03a03b460e8d7307

Adding a new IP range works as expected, but removing an IP range does not work, from UI, all the buttons are active and even the operator logs indicate that an update is in progress, but when the update finishes, there appears to be no change.

Steps to reproduce:

  1. Create an AKS cluster with two authorized IP ranges.
  2. Once the cluster is active, update it to remove one of the ranges OR uncheck Authorized IP Ranges.
  3. Monitor deploy/aks-config-operator logs to ensure the update is in progress.
  4. Once the update finishes, check the config.

The removed IP range is still present in both AKSConfig and UpstreamSpec.

Notes:

  1. The cluster does not go into Updating state, is this expected?
  2. Editing an existing IP range, adds a new one.

Ref: https://github.com/rancher/dashboard/issues/6879#issuecomment-2222294833

PR's

valaparthvi commented 1 month ago

@mjura @yiannistri Can this get some love?

valaparthvi commented 1 month ago

Fixed on Rancher v2.9-6e9cf233a87796ee9a96e73c096a82101fc9c2ff-head.

valaparthvi commented 1 month ago

The issue is still persistent. The IP range was removed, but then it got re-added after a few minutes.

valaparthvi commented 1 month ago

cc: @mjura @yiannistri

valaparthvi commented 4 weeks ago

Tested this again on Rancher (v2.9-0ab20e8fe6275887c52b97e94e15365f33b8afab-head); Dashboard(release-2.9 https://github.com/rancher/dashboard/commit/6e45e2fabb473335ca8975560b57d1657554ff27), aks-operator(rancher-aks-operator:104.1.0+up1.9.1-rc.4).

FIXED.