search

rancher / backup-restore-operator

Apache License 2.0
98 stars 67 forks source link

Mergo Related Build issues #540

Open mallardduck opened 1 month ago

mallardduck commented 1 month ago

Describe the bug We reverted bumps to mergo due to it causing build issues: https://github.com/rancher/backup-restore-operator/pull/539

Then I dug deeper and found k8s long standing issue about this topic here: https://github.com/kubernetes/kubernetes/issues/107499

At minimum BRO repo needs to adjust renovate to ignore the package. Maybe we consider reverting the mergo pin to use v0.3.5 like the k8s issue says.

That in mind, there are two (and a half) portions to fixing this issue:

  1. Immediate Solution: Add this package to renovate config ignore,
  2. Medium Term Solution: Evaluate if BRO/Wranger even depend on the behaviour changes that happen on varying mergo versions, 2.5 Consider Being the BEST FOSS community members: Do we dare consider to go fix the root issues behind this 2-3+ year long issue? Would first need to be fixed at mergo package, then they would (in theory) cut a v1.0.1 then kubernetes repo needs to be updated. THEN finally we as Rancher can update Wrangler and stuff.
mallardduck commented 1 month ago

Assigned @jbiers to work on part 1 of the issue. I'm not sure the best way to do task 2 though; so we won't rush that idea. Once you've corrected the renovate config and we've merged that PR, we'll just have you un-assign the issue.

Alternatively, you could also make a new issue to split out the Renovate change (mainly for tracking your work since it doesn't require QA).

jbiers commented 1 month ago

The immediate solution was implemented in PR #542

MKlimuszka commented 4 weeks ago

Proper fix is blocked until there are upstream changes.

mallardduck commented 1 week ago

Update on upstream changes concerns; k8s group confirmed they plan to remove the library. PRs to remove it are in progress and once they do merge those we can adjust wrangler accordingly and BRO after that.