[BUG] ConfigSecret name uses cached value which mismatches with provider

rancher / capi-ui-extension

Rancher Extension used in rancher/dashboard for Rancher Turtles CAPI Provisioning UI.

Apache License 2.0

8 stars 7 forks source link

Closed cpinjani closed 2 months ago

cpinjani commented 2 months ago

Setup Rancher version: v2.8-head Rancher Turtles: v0.6.0 Rancher UI Extensions: CAPI UI Extension v0.4.0 Browser type & version: Chrome Latest

To Reproduce

Install CAPI UI extension
Open Cluster Management > CAPI Menu
Open Infrastructure Providers > Create > Docker > Create
Now Create AWS Infra provider (Edit YAML and check ConfigSecret name) Config secret is created with name docker-credentials-*, if user does not edits YAML

Expected Result ConfigSecret name must match with provider or should be provider agnostic

Screenshots

eva-vashkevich commented 2 months ago

Hi, this was by design to avoid accidental name collision. Why do you think this is wrong?

cpinjani commented 2 months ago

Since it creates with name docker-credentials-* for all other providers which not matches with provider type, if below steps are performed:

Open Infrastructure Providers > Create > Docker > Create
Now Create AWS Infra provider or any other Infra provider and check configSecret name

eva-vashkevich commented 2 months ago

cpinjani commented 2 months ago

Validated as fixed on UI extension v0.5.0-rc1