Unable to update custom CAPIProvider version

cpinjani commented 2 months ago

What steps did you take and what happened?

Install turtles v0.11.0 on Rancher v2.9 via Rancher Dashboard

Install custom providers eg.

kubeadm-control-plane using YAML (do not provide version)

kubeadm-bootstrap using CAPI-UI extension, it creates using version

spec:
configSecret:
name: custom-credentials-xtczv
features:
clusterResourceSet: true
clusterTopology: true
machinePool: true
fetchConfig:
url: >-
https://github.com/kubernetes-sigs/cluster-api/releases/v1.4.6/bootstrap-components.yaml
name: kubeadm
type: bootstrap
variables: {}
**version: v1.4.6**

Upgrade turtles to v0.12

kubeadm-control-plane is auto-upgraded to v1.7.3 message: Updated to latest v1.7.3 version

kubeadm-bootstrap stays on v1.4.6 and unable to upgrade using ClusterctlConfig message: Provider version update available. Current latest is v1.7.3

What did you expect to happen?

CAPIProvider version should be auto-upgraded or User able to upgrade custom CAPIProvider version

How to reproduce it?

No response

Rancher Turtles version

v.0.12

Anything else you would like to add?

No response

Label(s) to be applied

/kind bug

salasberryfin commented 3 weeks ago

Thanks for reporting this @cpinjani and for helping me out with reproducing it. I was able to experience the behavior described in the issue. Since user provided a specific version during provider installation I think it would make sense that they are required to manually update to a newer version, as automatic updates may not align with their needs.

In this case I managed to update the version manually by editing the CAPIProvider resource, which I think should be the source of truth in this situation. Perhaps what is missing here is a way to let users know that there are newer versions available and a way for them to update the provider via UI, equivalent to what we have in Turtles. What do you think?

For cases where user did not configure a specific version, it's sensible that Turtles takes care of applying latest version available.

cpinjani commented 2 weeks ago

@salasberryfin Users get message that there are newer versions available from CAPIProvider status. Agreed there should be a way for them to get informed & update the provider via UI similar to below.

status:
  conditions:
    - lastTransitionTime: '2024-11-08T06:44:05Z'
      reason: MinimumReplicasAvailable
      status: 'True'
      type: Ready
    - lastTransitionTime: '2024-11-08T07:01:20Z'
      message: Provider version update available. Current latest is v1.7.7
      reason: UpdateAvailable
      severity: Info
      status: 'False'
      type: CheckLatestVersionTime

rancher / capi-ui-extension