Do not remove dependencies versions

rancher / charts-build-scripts

Apache License 2.0

9 stars 32 forks source link

Do not remove dependencies versions #118

Closed Kristian-ZH closed 8 months ago

Kristian-ZH commented 10 months ago

Issue - https://github.com/rancher/charts-build-scripts/issues/68

With this PR the dependencies versions will not be deleted when they are explicitly defined in the Chart.yaml file. They are sometimes necessary even in the local charts in Helm because, without the versions, the global Values file does not override the subchart values files (that is expected behavior in Helm)

hardys commented 10 months ago

I think this is related to https://github.com/rancher/charts-build-scripts/issues/68 - If we make this change it should resolve that issue?

hardys commented 10 months ago

/cc @rohitsakala

Kristian-ZH commented 10 months ago

Yes, this should resolve the mentioned issue

rohitsakala commented 9 months ago

TODO(@rohitsakala):

[x] Check if this is not a breaking change for all charts in rancher/charts.

rohitsakala commented 7 months ago

fixes https://github.com/rancher/charts-build-scripts/issues/68