Closed adamkpickering closed 2 months ago
Please hold off on reviewing this. It uses goreleaser
, which is not (yet?) on the list of allowed github actions. I will post another message here when I have an update.
I confirmed that we can use goreleaser
. This PR is ready for review.
It seems to me that the build process/CI for
charts-build-scripts
is convoluted. I get the sense that it came from a repository template, and many of the features of that template never were needed by this repository. Additionally, it uses Dapper; the last update to the Dapper image was in July 2022, and its use is discouraged by Rancher leadership.Since charts-build-scripts is a plain CLI tool, the tooling doesn't have to be complicated. This PR simplifies it. It uses the go toolchain,
golangci-lint
(which the repository already uses), andgoreleaser
(which is popular and effective - I've used it in the past) for releases. You can see what a release created bygoreleaser
looks like here.If others on MAPPS disagree with this way of doing things that is totally fine. I know I didn't put this to the team for discussion, so I may have missed something important. I knew that this wouldn't take very long, and it is sometimes easier to critique a working example rather than explaining how something is going to work.
If we merge this, we will need to modify https://github.com/rancher/charts/blob/dev-v2.9/scripts/pull-scripts.
As a bonus, fixes #121.