rancher / charts-build-scripts

Apache License 2.0
9 stars 31 forks source link

Allow CRD Charts to pull from an upstream #13

Closed aiyengar2 closed 7 months ago

aiyengar2 commented 3 years ago

An AdditionalChart that has CRDOptions should also be able to specify UpstreamOptions as long as templateDirectory is not set. This should trigger the charts to pull the chart base from a specified upstream and then move CRDs over to a given directory (conflicting filenames will be overridden).

Before releasing, we'll need to confirm generated changes for additional charts works as expected.

Running prepare should error out if a user specifies both upstream and templateDirectory. Eventually, we can completely deprecate the templateDirectory field by just storing the template directly in the workingDir of the CRD chart and using url: local.

Why?

This feature enhancement will allow us to use the packages/{packageName} mechanism to point to two new charts: rancher-crd-chart-base and rancher-crd-chart-assume-ownership.

Once this is done, we'll be able to maintain all of the CRD charts in two central packages instead of copying changes to templates across Backup, CIS, Monitoring, Kiali Server, etc.