search

rancher / charts-build-scripts

Apache License 2.0
9 stars 31 forks source link

Update CRD chart template version on prepare #41

Closed aiyengar2 closed 3 years ago

aiyengar2 commented 3 years ago

Solves this issue by adding a flag on prepare that can be set via an environment variable.

This fix causes no real impact to developers since it runs after prepare and is gated by an optional flag.

Related Issue: https://github.com/rancher/charts-build-scripts/issues/1

aiyengar2 commented 3 years ago

@jiaqiluo no rush to review this PR / get it merged in. Would be nice if we can get this in for the 0.2.1 release though.

aiyengar2 commented 3 years ago

@cbron I drafted this PR over the weekend to try to see if we could get it in the 0.2.1 release.

It adds an optional flag for prepare that allows you to automatically update the CRD chart version (it will also reformat the Chart.yaml based on the YAML parser we use if you have never run it before).

If you have time to review it, we can see if we can squeeze it in this release.

aiyengar2 commented 3 years ago

As mentioned in https://github.com/rancher/charts-build-scripts/pull/41#discussion_r643376351, I'm closing out this PR and updating the issue.