search

rancher / charts-build-scripts

Apache License 2.0
9 stars 32 forks source link

Move rancher/charts to a rancher/system-charts model for PRs #62

Closed aiyengar2 closed 2 years ago

aiyengar2 commented 2 years ago

In rancher/charts today, we have a somewhat complicated process for release that involves running a set of git commands in order to be able to checkout only specific directories.

Unlike that, in rancher/system-charts we simply need to make a PR from dev-v2.x -> release-v2.x, since both are based on the same Git tree. This is a far simpler process to follow for release captains and has the benefit of auto-updating release PRs the moment a dev merges something into the dev branch.

Therefore, we would like to switch the scripts to the older model by removing any differences between the staging and release branch so that we can easily merge PRs from one to the other.

This will also involve deprecating branch-specific make template commands, since both staging and release will maintain the same docs.

Epic Issue: https://github.com/rancher/charts-build-scripts/issues/60

aiyengar2 commented 2 years ago

Created dummy PR for testing merging packages/ from dev-v2.6 with all the git history saved https://github.com/aiyengar2/charts/pull/3.

Seems to have worked as expected! 🥳

aiyengar2 commented 2 years ago

docs changes should account for adding a section that was added in this PR: https://github.com/rancher/charts/pull/1508.