search

rancher / charts-build-scripts

Apache License 2.0
9 stars 32 forks source link

add the step of combining all CRD files into a single compressed file #64

Closed jiaqiluo closed 2 years ago

jiaqiluo commented 2 years ago

Issue: In the CRD chart, Helm combines all CRD files into one file and saves the file into a configMap, then Helm runs a pod to install/uninstall CRDs by reading the file from the configMap. But in the latest monitoring v2 chart, the creation of the configMap fails because the size exceeds the 1MB limit set by k8s. Also, the issue cannot be fixed in the Helm chart since Helm does not support compressing files.

Fix: When preparing the CRD chart, a new file that combines all CRDs is created and compressed by gzip. Then Helm chart can use this file to create the configMap. The CRD-chart templates in the rancher-monitoring package also need to be updated in order to use this new file. https://github.com/rancher/charts/pull/1567

jiaqiluo commented 2 years ago

@aiyengar2 Can we add this to the 3.0.0 epic?

aiyengar2 commented 2 years ago

@aiyengar2 Can we add this to the 3.0.0 epic?

Sure, if we can get this in.