search

rancher / charts-build-scripts

Apache License 2.0
9 stars 32 forks source link

Problem with chart dependencies #68

Open eliaskoromilas opened 2 years ago

eliaskoromilas commented 2 years ago

The following line messes with how Helm 3 handles dependencies:

https://github.com/rancher/charts-build-scripts/blob/v0.2.4/pkg/charts/dependencies.go#L257

more at https://github.com/rancher/partner-charts/pull/265

aiyengar2 commented 2 years ago

Thanks for bringing this up @eliaskoromilas; seems like we need to slightly modify the logic we use to add dependencies to also ensure versions for those dependencies are added.

This will require more investigation, but I think this can be done as part of a new minor release of the charts (since adding the versions to the Chart.yaml will invalidate existing patches recorded in Chart.yaml.patch files, which will require a manual migration process).