search

rancher / charts-build-scripts

Apache License 2.0
9 stars 32 forks source link

`release.yaml` outputted from `make validate` should merge with existing contents #77

Open aiyengar2 opened 2 years ago

aiyengar2 commented 2 years ago

Instead of starting with an empty ReleaseOptions{} here: https://github.com/rancher/charts-build-scripts/blob/bc4c3dadee9e35ddf52a6bf4e95e319642097dd1/pkg/validate/validate.go#L46

We should be loading the release.yaml from the existing file (if it exists), since all of our walk functions will not track existing items in the release.yaml that will be dumped anyways: https://github.com/rancher/charts-build-scripts/blob/bc4c3dadee9e35ddf52a6bf4e95e319642097dd1/pkg/validate/validate.go#L97-L103