search

rancher / charts-build-scripts

Apache License 2.0
9 stars 32 forks source link

Add rancher img validation #84

Closed superseb closed 2 years ago

superseb commented 2 years ago

First attempt at checking if all images start with rancher/. This is to catch this issue as early as possible, most of the code was taken from rancher/rancher as the test also happens there. See pkg/image for the code in rancher/rancher.

I also added a list-asset-images command that I want to use to get the images from added assets in a PR and check if the images actually exist in DockerHub to avoid issues later in the Rancher release.

Let me know if this needs to be done differently, or maybe added somewhere else.

pennyscissors commented 2 years ago

Would it make sense to convert the code in rancher/rancher into a Go module and pull it here to avoid duplication?

superseb commented 2 years ago

Yeah thought about that but it would mean a change in Rancher code as its not identical code currently, this also means we are blocked by Rancher to make changes. Also I think we will pull in too many dependencies if we depend on Rancher.

superseb commented 2 years ago

@PennyScissors @aiyengar2 Can you review to see if this is constructed correctly or if this needs a different approach/layout so I can work on getting it ready to merge

superseb commented 2 years ago

@aiyengar2 said this will be included in the next charts validation/testing tool