rancher / charts-build-scripts

Apache License 2.0
9 stars 32 forks source link

Support ignoreDependencies and replacePaths #87

Closed aiyengar2 closed 1 year ago

aiyengar2 commented 1 year ago

ignoreDependencies supports the ability to be able to drop dependencies grabbed by upstream in case a chart owner wants to omit such dependencies. For example, for Project Monitoring V2 we would like to omit all exporter charts without storing a ton of patches and exclude files.

replacePaths supports the ability to mark particular paths in a chart as ones that should not be stored under generated-changes/patches but instead be stored in both generated-changes/overlay and generated-changes/exclude. While this doesn't change any functionality per-say, it makes the contents of the generated-changes directory more readable.

aiyengar2 commented 1 year ago

Ran ./scripts/package-ci, found errors but they aren't due to the changes in this script since they appear in the latest charts-build-scripts too. Noted in https://github.com/rancher/charts-build-scripts/issues/90.

Upgrading should not cause issues to rancher/charts, but we won't need to upgrade rancher/charts with these changes unless necessary.