It doesn't have the same results on all machines since the version of diff used can be different.
To solve this, we should be using containerized rancher/charts-build-scripts runs instead of pulling in an appropriate charts-build-scripts binary to a machine (the current approach).
Drone / GitHub workflows need to be set up to actually create the rancher/charts-build-scripts images and put them in a publicly accessible Docker repository
Since charts-build-scripts directly exec the diff call, as seen here:
https://github.com/rancher/charts-build-scripts/blob/aa49bb9b0e39e8e7ea4119c8e379a1382126e8ba/pkg/diff/diff.go#L19
It doesn't have the same results on all machines since the version of diff used can be different.
To solve this, we should be using containerized rancher/charts-build-scripts runs instead of pulling in an appropriate charts-build-scripts binary to a machine (the current approach).
To do this, a couple of steps needs to be taken:
I pushed an image based on my current PR in https://github.com/rancher/charts-build-scripts/blob/master/templates/template/Makefile (based on
v0.4.2
) to my DockerHub fork for now, in case anyone wants to use it. To create your own, I ranREPO=arvindiyengar TAG=dev make build; REPO=arvindiyengar TAG=dev make package
.To run all the relevant commands in the containerized approach today, you can do that as follows: