rancher / cluster-template-examples

Apache License 2.0
43 stars 124 forks source link

Clarify comments for `.Values.rke.localClusterAuthEndpoint` #20

Open lindhe opened 1 year ago

lindhe commented 1 year ago

The field is named localClusterAuthEndpoint, but the comments talk about "local access endpoint". Is an access endpoint the same thing as an auth endpoint? This should be clarified (e.g. by using consistent terminology)!

Also: I assume these values regards the Authorized Cluster Endpoint feature. This should also be made clearer in the comments!

https://github.com/rancher/cluster-template-examples/blob/dc5c201c5415c430cdf4bcb6af975f9e516e970b/charts/values.yaml#L22-L28

staedter commented 7 months ago

Yes please do.

Also provide an example for the correct syntax for "caCerts"

Using this format, is apparently not supported when the inline yaml configuration gets converted to json. I tried other stuff for the multiline yaml, but none has worked sofar

image

image

Setting this as a base64 sting does work for the conversion. But then in the resulting kubeconfig the cert is double b64-encoded.

Please tell me how to set the caCerts correctly. Thank you.