rancher / cluster-template-examples

Apache License 2.0
43 stars 124 forks source link

"Compare Changes" doesn't match `values.yaml` #30

Open lindhe opened 1 year ago

lindhe commented 1 year ago

Using this repo as source, if I go and create a new repo, choose "cluster-template" and click "Compare Changes", the diff looks like this:

nodepools.0 is added

As we can see, it has added the object nodepools with the field '0'. So the type of nodepools is clearly object.

This is in contrast with the values.yaml where nodepools is a list of objects:

https://github.com/rancher/cluster-template-examples/blob/dc5c201c5415c430cdf4bcb6af975f9e516e970b/charts/values-vsphere.yaml#L6-L7

I assume that the intention here was to "create the list nodepools with x as the first element", not to "create the object nodepools with the field '0' with value x".

I haven't tried it, but it would surprise me greatly if it works with having nodepools as either an object or a list.

Ideally, I would like to have a menu for configuring nodepools similar to the one when creating a VMware vSphere cluster without templates:

nodepool menu without templates

lindhe commented 1 year ago

Seems like array type answers are not yet implemented: https://github.com/rancher/rancher/issues/13952