Closed wborn closed 6 years ago
@wborn Great work. Thank you! 👍
I've also created a community topic with details on how to run openHAB with Rancher.
Thanks for picking up the new logo so quickly 👍
Reviewed 5 of 14 files at r1, 1 of 2 files at r2, 8 of 8 files at r3. Review status: :shipit: all files reviewed at latest revision, all discussions resolved, all commit checks successful.
Comments from Reviewable
Review status: :shipit: all files reviewed at latest revision, all discussions resolved, all commit checks successful.
Comments from Reviewable
Hi @wborn , thanks for the nice PR. :)
Could you take a look to the requested changes?? Please, add managed
network mode option.
Thanks for reviewing this PR @rawmind0!
Getting the container in managed network mode is done by not setting any network_mode
at all in docker-compose.yml.tpl right?
{{- if ne .Values.NETWORK_MODE "managed"}}
network_mode: ${NETWORK_MODE}
{{- end}}
@rawmind0 I've added the managed network mode and succesfully tested it with Rancher. :slightly_smiling_face:
@wborn, thank for the changes. :)
LGTM...
Thank you too @rawmind0! I'll most likely be putting in a PR soon to also get the next stable openHAB version (2.2.0) added once the images have been uploaded to Docker Hub. :wink:
This PR adds support for using the openHAB Docker container in the Rancher community catalog.
The template options used for adding an openHAB stack to Rancher are based on the openHAB Docker instructions.
It will not provide openHAB 2.x as an upgrade option for openHAB 1.8.3 based stacks (due to incompatibilties).
The category of this catalog item is now set to "Automation" which does not yet exist. I.e. similar to that of the pending Home Assistant PR #604. I think it could also be categorized in the "IoT" category.
Comments by @kaikreuzer @cniweb @legacycode are also appreciated. :-)
Below follow some screenshots of the openHAB Rancher catalog entry:
Searching the catalog
Creating the stack
Showing container logging