Update Jenkins template to jenkins/jenkins and support multi version

rancher / community-catalog

Catalog entries contributed by the community

384 stars 636 forks source link

Update Jenkins template to jenkins/jenkins and support multi version #646

Closed heralight closed 6 years ago

heralight commented 7 years ago

Update Jenkins template to jenkins/jenkins and support version with question.

lts
lts-alpine
... etc.

rPawel commented 6 years ago

I'd really appreciate if this PR would get merged. The current template is heavily outdated, and forced upgrades outside of the main pipeline are rather tedious. Also, current _/jenkins has been deprecated and is not receiving any updates. This PR is switching to jenkins/jenkins which is a huge win.

heralight commented 6 years ago

You can, just rename it, my push was done before version 4 was created... For the little story, I do not understand why rancher does not systematically put images and image versions as default options (one string, with this mechanism, we can use fork), it's a real waste of time to have to maintain things so fluctuating and not very useful ...

chrisurwin commented 6 years ago

@rPawel the latest template in Rancher already uses jenkins/jenkins as the base. @heralight We need to have specific versions in a template in order to allow for the catalog to check if there is an upgrade available.

heralight commented 6 years ago

@heralight We need to have specific versions in a template in order to allow for the catalog to check if there is an upgrade available.

I 'm not talking about template rancher version, which is good and understand, I talk about template code like that: image: "jenkins/jenkins:2.92"

which from my point of is useless because:

fix version version
cannot use or test a fork
need maintenance

I prefer something like I push: image: "${jenkins_image}" with a default value. For me a template need to generic and open as more as we can... to fit any simple situation.

Actually, your jenkins template implementation need maintenance and will be outdated soon... then useless...

chrisurwin commented 6 years ago

People don't necessarily want to check what version they should be running, so if you put a default how do you then notify of a change, if you update the default you are in the same position you are now.

The catalog is a simple way to deploy applications, more advanced users will tend to create their own private catalog and maintain it themselves, or take the rancher/docker-compose files and tweak it to their needs.

You can test a new version by creating a private catalog, which you can fork and the catalog service supports