search

rancher / community-catalog

Catalog entries contributed by the community
384 stars 636 forks source link

new catalog item: cowcheck #681

Closed wjimenez5271 closed 6 years ago

rawmind0 commented 6 years ago

Hi @wjimenez5271 , thanks so much for the PR. :)

Build is failing due to bad questions indent. Could you please take a look at changes requested??

wjimenez5271 commented 6 years ago

@rawmind0 I've updated the PR, however it still failing but I can't tell why

rawmind0 commented 6 years ago

@wjimenez5271, build is failing now due to description fields at rancher-compose. Please, take a look at the changes requested.

Also, could you please add templates/cowcheck/catalogIcon-cowcheck.svg (prefered) or templates/cowcheck/catalogIcon-cowcheck.png icon to show into the catalog entry??

rawmind0 commented 6 years ago

Thanks for the update @wjimenez5271...

If i deploy the packages with default values, i got these error logs...

21/12/2017 10:35:34panic: non-positive interval for NewTicker
21/12/2017 10:35:34
21/12/2017 10:35:34goroutine 20 [running]:
21/12/2017 10:35:34time.NewTicker(0x0, 0x3)
21/12/2017 10:35:34 /usr/local/Cellar/go/1.9/libexec/src/time/tick.go:23 +0x1d0
21/12/2017 10:35:34main.checkPoller(0xc42030c2a0, 0x3, 0x3, 0x0)
21/12/2017 10:35:34 /Users/wjimenez/go/src/github.com/wjimenez5271/cowcheck/main.go:270 +0x58
21/12/2017 10:35:34created by main.main
21/12/2017 10:35:34 /Users/wjimenez/go/src/github.com/wjimenez5271/cowcheck/main.go:333 +0x33d

If i change default values, the package run correctly. Could you please take a look to the changes requested to set correct default values??

wjimenez5271 commented 6 years ago

@rawmind0 sorry Raul, I don't know how I missed those defaults, you're right they are completely wrong

rawmind0 commented 6 years ago

No problem @wjimenez5271 ... Right now is ok.. :)

LGTM...