search

rancher / community-catalog

Catalog entries contributed by the community
385 stars 641 forks source link

Added: template for NSQ cluster #708

Closed mschneider82 closed 6 years ago

mschneider82 commented 6 years ago

Added support for NSQ Message Broker! www.nsq.io

rawmind0 commented 6 years ago

Hi @mschneider82 , thanks so much for the PR.

Please, take a look to the requested changes.

mschneider82 commented 6 years ago

looks good thanks! I recommend to keep the 3 static nsqlookupd and dont do the port mapping. (see comments above)

mschneider82 commented 6 years ago

just tested the changes, looks good.

rawmind0 commented 6 years ago

@mschneider82 thanks for the update.

Package is working well, but i have some concerns about nsqlookupd0N services. There is no control neither warranty that they would be deployed in a distributed way. e.g. in my test env, all 3 are running in same host. If you don't want to deal with system discovery to generate dynamic config, what do you think to add an affinity rule (soft or hard) to nsqlookupd0N services to assure distribution across the hosts?? Same for nsqadmin.

Please, take a look at changes requested.

mschneider82 commented 6 years ago

What do you think about scaling nsq-lb globally?

rawmind0 commented 6 years ago

I think it could be a good idea to scale nsq-lb as well..Globally with host labels would be nice.. :)

rawmind0 commented 6 years ago

@mschneider82 , tell me if you want to include global lb scheduling in the PR.

rawmind0 commented 6 years ago

May be adding a comment about lb label in the README.md file would be useful. ;)

rawmind0 commented 6 years ago

Cool...Thanks for the update @mschneider82 ..

LGTM..