search

rancher / community-catalog

Catalog entries contributed by the community
385 stars 641 forks source link

add filebeat for rancher catalog for fast deployment #733

Closed easonlau02 closed 6 years ago

easonlau02 commented 6 years ago

Hi guys,

Here to add filebeat 6.1.1 for rancher catalog for fast deployment. Hope we can use at the rancher community catalog. Please kindly help review. Thanks.

Regards/Eason

easonlau02 commented 6 years ago

Updated and passed checking. @rawmind0

rawmind0 commented 6 years ago

Hi @easonlau02 , thanks for PR and the changes.

You are assuming that the package would be run at host level, forcing network_mode and bind volumes to get config and logs files. What do you think to add distinct volumes driver as bind, nfs,... to make the package more versatile?? May be better if ${APPLOG_PATH} and ${NGINXLOG_PATH} volumes would be mounted in read-only mode??

Also network-mode could be managed too if logstash would be running inside rancher. What do you think add hosts or managed option??

easonlau02 commented 6 years ago

hi @rawmind0, thanks for your fast review.

For ${APPLOG_PATH} and ${NGINXLOG_PATH} indeed need read-only. let me update. But for network-mode, I don't think let it as managed, which can prevent from running with logstash as one host, so that someone maybe set it as localhost.

Now let network-mode as host, which will support logstash host as localhost or server name or domain. What do you think about this??

rawmind0 commented 6 years ago

I get your point @easonlau02, thanks for the changes.

LGTM...