search

rancher / community-catalog

Catalog entries contributed by the community
385 stars 641 forks source link

Allowing TTL to be specified by Env var #761

Closed benyanke closed 6 years ago

benyanke commented 6 years ago

This should really be a configurable option

rawmind0 commented 6 years ago

Hi @benyanke , thanks for the PR and contribute.

Couple of questions, why are your updating files at infra-templates/digitalocean-dns/0 and infra-templates/digitalocean-dns/3 versions?? Why don't you update all versions or just the last one??

benyanke commented 6 years ago

I previously misunderstood the versioning - I see the issue with that now. Is there an easy way to delete a commit from a PR or should I start over?

rawmind0 commented 6 years ago

You could do it with git reset --hard <commit_id> in your forked repo. If not you could start over.

benyanke commented 6 years ago

ok, force pushed my cleaned up branch - give it a look. Thanks @rawmind0

rawmind0 commented 6 years ago

Thanks @benyanke ..

LGTM...