rancher / convoy

A Docker volume plugin, managing persistent container volumes.
Apache License 2.0
1.31k stars 135 forks source link

Fix error discarding device when delete volumes #105

Closed jinuxstyle closed 8 years ago

jinuxstyle commented 8 years ago

When deleting volumes, convoy daemon will always log error messages like following:

"Error open volume-e4956a83f67147c0: no such file or directory when discarding volume-e4956a83f67147c0, ignored pkg=devmapper"

This patch fixes it by passing correct argument to the API devicemapper.BlockDeviceDiscard which expects a full path of a device instead of just device name.

Signed-off-by: Jin Xu jinuxstyle@hotmail.com Reviewed-by: Sheng Yang sheng.yang@rancher.com

V2: use filepath.Join to generate the full path

yasker commented 8 years ago

Merged. Thanks!