search

rancher / convoy

A Docker volume plugin, managing persistent container volumes.
Apache License 2.0
1.31k stars 135 forks source link

Command line options for daemon not effective after first run #108

Closed jinuxstyle closed 8 years ago

jinuxstyle commented 8 years ago

Convoy saves command lines to configure files for the first successful run, and later on when user starts the daemon again with different command line options, convoy will ignore the new command line if it finds configure files for the daemon. This causes problems like #103 and #94.

jinuxstyle commented 8 years ago

I submitted a patch for this problem in pull request #95, but it turns out not be a thorough thorough solution as @yasker commented.

After analyzing the three types of configure files including general, driver and volume configure files, I'd like to propose another solution which is actually an improvement of the previous one. It has following main points:

  1. Still add the ignore-config-file option for expressing user's intention to change command line options.
  2. With the option specified, convoy should and could ignore the general configure file named convoy.cfg because it would not affect existing volumes. For the driver and volume configure files, convoy should ignore them only when there is no volume for the driver user specified in the new command line. In other words, if there is no volume for a driver, user can change the driver options without problem.

Comments?

yasker commented 8 years ago

Merged #120, this one can be closed.