rancher / convoy

A Docker volume plugin, managing persistent container volumes.
Apache License 2.0
1.31k stars 135 forks source link

adding convoy change for k8s client #161

Closed jimengliu closed 8 years ago

jimengliu commented 8 years ago

@yasker

First part, it contains convoy changes in order to support k8s flex volume plugin, including daemon and API changes. It is supposed not to break existing convoy functionality.

Second part, it contains k8s flex volume driver as a convoy client. There are some requirements from k8s driver side.

Second part code changes include:

yasker commented 8 years ago

I don't see your comment here related to any of actual change of the code here.

You've introduced two new VolumeMountRequest and one more new field in VolumeCreateRequest, and at least one additional function for EBS to deal with volume attached on the other host. How can all these in one commit and without any explain of what's happened?

jimengliu commented 8 years ago

added more concrete comments related to changes

yasker commented 8 years ago

Close this one in favor of another solution.

offlinehacker commented 7 years ago

What is another solution?