search

rancher / convoy

A Docker volume plugin, managing persistent container volumes.
Apache License 2.0
1.31k stars 135 forks source link

Revert "Ebs kms and storage types" #166

Closed dtx closed 8 years ago

dtx commented 8 years ago

Reverts rancher/convoy#154

This is breaking Convoy for all volumes created using convoy before this merge. The committer needs to find a better way to handle KMSKeyIDs, it is not a device configuration to be applied to all volumes by force.

dtx commented 8 years ago 
Oct 12 23:42:19 ip-10-240-28-39.us-west-1.compute.internal convoy[7637]: time="2016-10-12T23:42:19Z" level=error msg="Caught FATAL error: runtime error: invalid memory address or nil pointer dereference"
Oct 12 23:42:19 ip-10-240-28-39.us-west-1.compute.internal convoy[7637]: goroutine 1 [running]:
Oct 12 23:42:19 ip-10-240-28-39.us-west-1.compute.internal convoy[7637]: runtime/debug.Stack(0x0, 0x0, 0x0)
Oct 12 23:42:19 ip-10-240-28-39.us-west-1.compute.internal convoy[7637]: /usr/local/go/src/runtime/debug/stack.go:24 +0x80
Oct 12 23:42:19 ip-10-240-28-39.us-west-1.compute.internal convoy[7637]: runtime/debug.PrintStack()
Oct 12 23:42:19 ip-10-240-28-39.us-west-1.compute.internal convoy[7637]: /usr/local/go/src/runtime/debug/stack.go:16 +0x18
Oct 12 23:42:19 ip-10-240-28-39.us-west-1.compute.internal convoy[7637]: github.com/rancher/convoy/api.ResponseLogAndError(0xb8f9c0, 0xc82000e070)
Oct 12 23:42:19 ip-10-240-28-39.us-west-1.compute.internal convoy[7637]: /go/src/github.com/rancher/convoy/api/response.go:70 +0x6ce
Oct 12 23:42:19 ip-10-240-28-39.us-west-1.compute.internal convoy[7637]: github.com/rancher/convoy/daemon.environmentCleanup()
Oct 12 23:42:19 ip-10-240-28-39.us-west-1.compute.internal convoy[7637]: /go/src/github.com/rancher/convoy/daemon/daemon.go:216 +0x154
Oct 12 23:42:19 ip-10-240-28-39.us-west-1.compute.internal convoy[7637]: panic(0xb8f9c0, 0xc82000e070)
Oct 12 23:42:19 ip-10-240-28-39.us-west-1.compute.internal convoy[7637]: /usr/local/go/src/runtime/panic.go:443 +0x4e9
Oct 12 23:42:19 ip-10-240-28-39.us-west-1.compute.internal convoy[7637]: github.com/rancher/convoy/ebs.(*Driver).GetVolumeInfo(0xc820059320, 0xc8201bb917, 0x40, 0x0, 0x0, 0x0)
Oct 12 23:42:19 ip-10-240-28-39.us-west-1.compute.internal convoy[7637]: /go/src/github.com/rancher/convoy/ebs/ebs.go:537 +0x898
Oct 12 23:42:19 ip-10-240-28-39.us-west-1.compute.internal convoy[7637]: github.com/rancher/convoy/ebs.(*Driver).ListVolume(0xc820059320, 0xc82010df80, 0xc82010df80, 0x0, 0x0)
Oct 12 23:42:19 ip-10-240-28-39.us-west-1.compute.internal convoy[7637]: /go/src/github.com/rancher/convoy/ebs/ebs.go:560 +0x176
Oct 12 23:42:19 ip-10-240-28-39.us-west-1.compute.internal convoy[7637]: github.com/rancher/convoy/daemon.(*daemon).getVolumeList(0xc820082580, 0x30)
Oct 12 23:42:19 ip-10-240-28-39.us-west-1.compute.internal convoy[7637]: /go/src/github.com/rancher/convoy/daemon/volume.go:530 +0x183
Oct 12 23:42:19 ip-10-240-28-39.us-west-1.compute.internal convoy[7637]: github.com/rancher/convoy/daemon.(*daemon).updateIndex(0xc820082580, 0x0, 0x0)
Oct 12 23:42:19 ip-10-240-28-39.us-west-1.compute.internal convoy[7637]: /go/src/github.com/rancher/convoy/daemon/daemon.go:154 +0x45
Oct 12 23:42:19 ip-10-240-28-39.us-west-1.compute.internal convoy[7637]: github.com/rancher/convoy/daemon.(*daemon).finializeInitialization(0xc820082580, 0x0, 0x0)
Oct 12 23:42:19 ip-10-240-28-39.us-west-1.compute.internal convoy[7637]: /go/src/github.com/rancher/convoy/daemon/daemon.go:225 +0x1d7
Oct 12 23:42:19 ip-10-240-28-39.us-west-1.compute.internal convoy[7637]: github.com/rancher/convoy/daemon.Start(0xc8200b92e0, 0x1b, 0xc8200f1560, 0x0, 0x0)
Oct 12 23:42:19 ip-10-240-28-39.us-west-1.compute.internal convoy[7637]: /go/src/github.com/rancher/convoy/daemon/daemon.go:320 +0x7aa
Oct 12 23:42:19 ip-10-240-28-39.us-west-1.compute.internal convoy[7637]: github.com/rancher/convoy/client.startDaemon(0xc8200f1560, 0x0, 0x0)
Oct 12 23:42:19 ip-10-240-28-39.us-west-1.compute.internal convoy[7637]: /go/src/github.com/rancher/convoy/client/daemon.go:55 +0x45
Oct 12 23:42:19 ip-10-240-28-39.us-west-1.compute.internal convoy[7637]: github.com/rancher/convoy/client.cmdStartDaemon(0xc8200f1560)
Oct 12 23:42:19 ip-10-240-28-39.us-west-1.compute.internal convoy[7637]: /go/src/github.com/rancher/convoy/client/daemon.go:49 +0x21
Oct 12 23:42:19 ip-10-240-28-39.us-west-1.compute.internal convoy[7637]: github.com/rancher/convoy/vendor/github.com/codegangsta/cli.Command.Run(0xcb4cd8, 0x6, 0x0, 0x0, 0x0, 0x0, 0x0, 0xd48ad0, 0x13, 0x0, ...)
Oct 12 23:42:19 ip-10-240-28-39.us-west-1.compute.internal convoy[7637]: /go/src/github.com/rancher/convoy/vendor/github.com/codegangsta/cli/command.go:137 +0x1081
Oct 12 23:42:19 ip-10-240-28-39.us-west-1.compute.internal convoy[7637]: github.com/rancher/convoy/vendor/github.com/codegangsta/cli.(*App).Run(0xc8200f1320, 0xc82000a0a0, 0xa, 0xa, 0x0, 0x0)
Oct 12 23:42:19 ip-10-240-28-39.us-west-1.compute.internal systemd[1]: convoy.service: main process exited, code=exited, status=1/FAILURE
Oct 12 23:42:19 ip-10-240-28-39.us-west-1.compute.internal systemd[1]: Unit convoy.service entered failed state.
Oct 12 23:42:19 ip-10-240-28-39.us-west-1.compute.internal systemd[1]: convoy.service failed.
dtx commented 8 years ago

I will fix the bug and submit another PR (y)