rancher / convoy

A Docker volume plugin, managing persistent container volumes.
Apache License 2.0
1.31k stars 135 forks source link

Backups list does not work with EBS driver #199

Open peebles opened 7 years ago

peebles commented 7 years ago

I see the code in the ebs driver:

func (d *Driver) ListBackup(destURL string, opts map[string]string) (map[string]map[string]string, error) {
        //EBS doesn't support ListBackup(), return empty to satisfy caller
        return map[string]map[string]string{}, nil
}

So, if I want to restore a volume named "vol1" from a backup, how would I do this? I need a list of backups; their dates and URLs so I can choose the right restore point.

In EBS, the backups are really just the snapshots. So the list of snapshots associated with a volume is also the list of backups ... snapshots[ name ].DriverInfo.EBSSnapshotID is the backup (ebs://xxx) and CreatedTime was the time created.

I think this information should be returned with the ebs:// tacked onto it, so that the EBS driver works like the others, and so someone can find appropriate backups for doing a restore.

Or, am I on the wrong track?