Optional S3 access key and S3 secret key as arguments for security purpose.

rancher / convoy

A Docker volume plugin, managing persistent container volumes.

Apache License 2.0

1.31k stars 135 forks source link

Optional S3 access key and S3 secret key as arguments for security purpose. #232

Closed gopi-ideas2it closed 4 years ago

yasker commented 5 years ago

Please remove the access key/secret key from test script immediately if they're real. (force push)

And why we need this?

gopi-ideas2it commented 5 years ago

Access Key and Secret Key which I used are dummy values as used for Minio demo. In scenario's of deploying convoy in multicluster environment and we can't afford to set the access/secret key in ~/.aws/credentials or as environment variable as it might be a huge security risk on some cases. So we can just pass it as arguments.

cjellick commented 4 years ago

Closing this due to staleness. Feel free to reopen or open a new PR if there's still a relevant change to be made. Thanks!