rancher / dapper

Docker build wrapper
Apache License 2.0
365 stars 88 forks source link

Support Windows named pipe mount like Linux socket #70

Closed thxCode closed 5 years ago

thxCode commented 5 years ago

Testing Windows image package logic

  1. Set up a Windows server with Docker installed, for example, create a Windows Server 2019 instance from GCP: image
  2. Clone rancher/dapper into a directory
  3. Download pre-built Windows named pipe support dapper binary:
    iwr -Uri http://ppqhrn2y6.bkt.gdipper.com/dapper_amd64.exe -OutFile ${dapper repo dir}/.dapper.exe -UseBasicParsing
  4. Run image package logic:
    make.bat release
orangedeng commented 5 years ago

LGTM

ibuildthecloud commented 5 years ago

LGTM for the stuff I care about :) I didn't review the windows stuff because I know nothing about that. The changes to the existing code is good :+1: