rancher / dashboard

The Rancher UI
https://rancher.com
Apache License 2.0
450 stars 256 forks source link

Split check-plugins-build workflow and test-plugins-build script in more steps for readability #10112

Open cnotv opened 9 months ago

cnotv commented 9 months ago

Description

The existing job check-plugins-build/validate has exclusively one huge step Validate Plugin build system where a very extensive and long script does several checks. It is overwhelming to understand errors returned from this job every time and is necessary to split the internal logic in more steps or steps.

Steps

Example

1

PR: https://github.com/rancher/dashboard/pull/9686 Failing Check: https://github.com/rancher/dashboard/actions/runs/7089716715/job/19295057343?pr=9686#step:4:363 Log:

Screenshot 2023-12-04 at 18 21 42

2

Difficulty to reproduce it locally to identify the issue.

PR: https://github.com/rancher/dashboard/pull/8654 (comment) Failing Check: log overdue

3

PR: https://github.com/rancher/dashboard/pull/11420 Log: https://github.com/rancher/dashboard/actions/runs/9936497431/job/27444856722?pr=11420#logs

Difficulty to understand the missing/broken step.

cnotv commented 2 months ago

Current state: https://github.com/rancher/dashboard/commit/f1778eb2f8caf1c3b3b9f1a258380354b5800c6c

cnotv commented 2 months ago

I would enphatize that the debugging of this workflow is overwhelmingly complex and in some cases impossible. It would be recommended to create a scenario where this may be handled quicker, e.g. add more artifacts, define local installation without third parts and use just NPM.

Use of Yarn2 and newer yarn link is discouraged.