search

rancher / dashboard

The Rancher UI
https://rancher.com
Apache License 2.0
450 stars 256 forks source link

Fleet "continous delivery dashboard" should show Clusters/Bundles/Resources in error at "mouse over" #10339

Open nwmac opened 7 months ago

nwmac commented 7 months ago

Internal Reference: SURE-5804

In the fleet dashboard, when a Cluster,Bundle or Resource has errors it would be nice if the mouse over would show those which are in the error state.

We should use the current tooltips to show the items in an error state.

gaktive commented 5 months ago

Talk to @kwwii if there are any questions but the design is locked in. The backend will return an error state so there's no reason to dig into the reason state.

aalves08 commented 5 months ago

@edenhernandez-suse have all the issues been resolved here about the content and the states? Am I supposed to replace the current tooltip's content with this new one?

edenhernandez-suse commented 5 months ago

@gaktive @kwwii it currently shows how many items are in different states:

image

If we change that for a simple list with all the items with just any of those states, we might be losing information.

But even if we consider that solution as a good option, it looks like what we get is just the amount of items per state, so I believe @aalves08 can't infer which items are in those error states. That's why we need to talk with someone in the backend team, but I don't know which team is in charge of Fleet.

aalves08 commented 5 months ago

We are getting, per item, the statuses for each of the bundles and resources, not for clusters. That shouldn't be a problem, I think, since we need to get all of the clusters belonging to that particular namespace.

The main question that @edenhernandez-suse had (correct me if I am wrong) is what constitutes an "error state"... Being "not ready" is an error?

Also, are we sure we want to replace the content of the current tooltip (as shown in comment before this one) with the new content (designed)?

aalves08 commented 4 months ago

@nwmac according to our conversation, should we bump this to a different milestone?

nwmac commented 4 months ago

@aalves08 Is there much left to do on this? Should we push this to 2.10 to give ourselves time?

aalves08 commented 4 months ago

@nwmac tbh, I don't even remember what was the last solution me and @edenhernandez-suse agreed upon, but I remember I chatted with you about some issue and you told me to put it to a halt. I would say we should revisit this in 2.10

edenhernandez-suse commented 4 months ago

@aalves08 didn't you fix the Cluster count and finish the badges to make them clickable? You sent me a video with the working solution and it was perfect.

The final solution was this: Adobe Xd Prototype

aalves08 commented 4 months ago

@edenhernandez-suse I did, yes, now that I remember. But I had a couple of questions that I asked Neil about it afterwards (probably some tech details) which I don't remember right now and @nwmac told me to park it for now...

Sorry guys, that's the best info I can provide right now. I can revisit the PR to see where I left it off and check if I can remember why it got stopped.