rancher / dashboard

The Rancher UI
https://rancher.com
Apache License 2.0
461 stars 261 forks source link

[BUG] Clusters in error state can be reached but not clicked #10754

Open lindhe opened 7 months ago

lindhe commented 7 months ago

Rancher Server Setup

Information about the Cluster

User Information

Describe the bug

We have some downstream clusters in the "Error" state. When they are in this state, they cannot be reached by clicking on them in Rancher's GUI. But if one happens to have a link to the cluster's page (e.g. https://rancher.example.com/dashboard/c/c-m-1id3bjdio/), then most functionality is still available. Either the cluster is not supposed to be reachable via Rancher at all, and the link should be disabled, or the link should be easy to find (e.g. by clicking on the cluster name like normal).

To Reproduce

Have at least one downstream cluster in the "Error" state. (I do not know how to reproduce that)

Result

The cluster can be reached via its link but not by clicking in the GUI.

Expected Result

Either, cluster access should be disabled completely (disabling the link too) or one should get to the cluster explorer by clicking the cluster's name (like with healthy clusters).

Screenshots

The red clusters cannot be reached by clicking on them, but if one have a link since before they became red then they can be browsed anyway:

image

rak-phillip commented 7 months ago

@lindhe thanks for raising this issue and helping to make Rancher better! We'll follow up on this issue to request more information, if needed, as we triage.

@gaktive I'm transferring this issue to the Dashboard repo for triage.

rak-phillip commented 7 months ago

This could be related to #10043, where we started taking into account the readiness of a cluster before disabling the link if there is an error^1

@lindhe it sounds like the clusters in question might be in ready state but is now "faulty". Can you confirm that this is the case?

richard-cox commented 7 months ago

Given the UI depends on Rancher working correctly for many many things, think the best path is to redirect users away from anything with a cluster context to the home page if the cluster is not ready.

This might not be a 2.9.0 thing though.

lindhe commented 7 months ago

@rak-phillip Thank you for the input! I'll try and check that issue and see if it seems to be the same state.

lindhe commented 7 months ago

it sounds like the clusters in question might be in ready state but is now "faulty". Can you confirm that this is the case?

I'm not sure how to check for exactly what you are asking, but I think it looks like the cluster is in an error state and should not be considered ready:

image

image