rancher / dashboard

The Rancher UI
https://rancher.com
Apache License 2.0
452 stars 257 forks source link

[BUG] RKE2/K3s cluster configs not defined when attempting to create a second cluster of the same type as a cluster member #11166

Closed nickwsuse closed 3 months ago

nickwsuse commented 4 months ago

Setup

Describe the bug For users that are cluster/project members, if you create an RKE2 cluster and then attempt to create another one, there's an error displayed stating Cannot set properties of undefined (setting '<cluster_type>')

example 1: Custom Cluster - Cannot set properties of undefined (setting 'io.cattle.provisioning.v2.Cluster') example 2: Different error - k(t.store] is undefined

If you toggle the cluster type from RKE2/K3s to RKE1, and then toggle it back to RKE2/K3s that seems to resolve the issue until another cluster is created.

To Reproduce

  1. Deploy Rancher v2.9-head
  2. Provision a downstream RKE2 cluster
  3. Go to /dashboard/c/_/auth/management.cattle.io.user
  4. Create a new standard user (u1)
  5. In the downstream RKE2 cluster, assign u1 as a cluster and project member
  6. In a new/private browser window, log into the Rancher instance as u1
  7. Go to /dashboard/c/_/manager/provisioning.cattle.io.cluster
  8. Click the Create button in the upper right of the page
  9. Leave the toggle set to RKE2/K3s
  10. Provision a new cluster (I used EC2)
  11. After the cluster has been created, click the Create button again
  12. Select the same node provider used in step 10

Result Users get an error when trying to create multiple rke2/k3s clusters

Expected Result Users can deploy multiple rke2/k3s clusters with no error

Screenshots image image

momesgin commented 4 months ago

I could reproduce this with DigitalOcean. It happens when it hits this line of the code.

Screenshot 2024-06-03 at 12 55 47 PM

I added a console log there and got undefined for store, console.log({type, sd, SchemaDefinitionCache, store: this.store }):

{
    "type": "io.cattle.rke-machine-config.v1.DigitaloceanConfig",
    "sd": {
        "resourceFields": {
            "accessToken": {
                "type": "string",
                "description": "Digital Ocean access token"
            },
            "apiVersion": {
                "type": "string",
                "description": "APIVersion defines the versioned schema of this representation of an object. Servers should convert recognized schemas to the latest internal value, and may reject unrecognized values. More info: https://git.k8s.io/community/contributors/devel/sig-architecture/api-conventions.md#resources"
            },
            "backups": {
                "type": "boolean",
                "description": "enable backups for droplet"
            },
            "image": {
                "type": "string",
                "description": "Digital Ocean Image"
            },
            "ipv6": {
                "type": "boolean",
                "description": "enable ipv6 for droplet"
            },
            "kind": {
                "type": "string",
                "description": "Kind is a string value representing the REST resource this object represents. Servers may infer this from the endpoint the client submits requests to. Cannot be updated. In CamelCase. More info: https://git.k8s.io/community/contributors/devel/sig-architecture/api-conventions.md#types-kinds"
            },
            "metadata": {
                "type": "io.k8s.apimachinery.pkg.apis.meta.v1.ObjectMeta",
                "description": "Standard object's metadata. More info: https://git.k8s.io/community/contributors/devel/sig-architecture/api-conventions.md#metadata"
            },
            "monitoring": {
                "type": "boolean",
                "description": "enable monitoring for droplet"
            },
            "privateNetworking": {
                "type": "boolean",
                "description": "enable private networking for droplet"
            },
            "region": {
                "type": "string",
                "description": "Digital Ocean region"
            },
            "size": {
                "type": "string",
                "description": "Digital Ocean size"
            },
            "sshKeyContents": {
                "type": "string",
                "description": "File contents for sshKeyContents"
            },
            "sshKeyFingerprint": {
                "type": "string",
                "description": "SSH key fingerprint"
            },
            "sshPort": {
                "type": "string",
                "description": "SSH port"
            },
            "sshUser": {
                "type": "string",
                "description": "SSH username"
            },
            "tags": {
                "type": "string",
                "description": "comma-separated list of tags to apply to the Droplet"
            },
            "userdata": {
                "type": "string",
                "description": "File contents for userdata"
            }
        },
        "type": "io.cattle.rke-machine-config.v1.DigitaloceanConfig",
        "description": ""
    },
    "SchemaDefinitionCache": {
        "management": {
            "io.cattle.rke-machine-config.v1.DigitaloceanConfig": {
                "resourceFields": {
                    "accessToken": {
                        "type": "string",
                        "description": "Digital Ocean access token"
                    },
                    "apiVersion": {
                        "type": "string",
                        "description": "APIVersion defines the versioned schema of this representation of an object. Servers should convert recognized schemas to the latest internal value, and may reject unrecognized values. More info: https://git.k8s.io/community/contributors/devel/sig-architecture/api-conventions.md#resources"
                    },
                    "backups": {
                        "type": "boolean",
                        "description": "enable backups for droplet"
                    },
                    "image": {
                        "type": "string",
                        "description": "Digital Ocean Image"
                    },
                    "ipv6": {
                        "type": "boolean",
                        "description": "enable ipv6 for droplet"
                    },
                    "kind": {
                        "type": "string",
                        "description": "Kind is a string value representing the REST resource this object represents. Servers may infer this from the endpoint the client submits requests to. Cannot be updated. In CamelCase. More info: https://git.k8s.io/community/contributors/devel/sig-architecture/api-conventions.md#types-kinds"
                    },
                    "metadata": {
                        "type": "io.k8s.apimachinery.pkg.apis.meta.v1.ObjectMeta",
                        "description": "Standard object's metadata. More info: https://git.k8s.io/community/contributors/devel/sig-architecture/api-conventions.md#metadata"
                    },
                    "monitoring": {
                        "type": "boolean",
                        "description": "enable monitoring for droplet"
                    },
                    "privateNetworking": {
                        "type": "boolean",
                        "description": "enable private networking for droplet"
                    },
                    "region": {
                        "type": "string",
                        "description": "Digital Ocean region"
                    },
                    "size": {
                        "type": "string",
                        "description": "Digital Ocean size"
                    },
                    "sshKeyContents": {
                        "type": "string",
                        "description": "File contents for sshKeyContents"
                    },
                    "sshKeyFingerprint": {
                        "type": "string",
                        "description": "SSH key fingerprint"
                    },
                    "sshPort": {
                        "type": "string",
                        "description": "SSH port"
                    },
                    "sshUser": {
                        "type": "string",
                        "description": "SSH username"
                    },
                    "tags": {
                        "type": "string",
                        "description": "comma-separated list of tags to apply to the Droplet"
                    },
                    "userdata": {
                        "type": "string",
                        "description": "File contents for userdata"
                    }
                },
                "type": "io.cattle.rke-machine-config.v1.DigitaloceanConfig",
                "description": ""
            },
            "io.k8s.apimachinery.pkg.apis.meta.v1.ManagedFieldsEntry": {
                "resourceFields": {
                    "apiVersion": {
                        "type": "string",
                        "description": "APIVersion defines the version of this resource that this field set applies to. The format is \"group/version\" just like the top-level APIVersion field. It is necessary to track the version of a field set because it cannot be automatically converted."
                    },
                    "fieldsType": {
                        "type": "string",
                        "description": "FieldsType is the discriminator for the different fields format and version. There is currently only one possible value: \"FieldsV1\""
                    },
                    "fieldsV1": {
                        "type": "map",
                        "subtype": "string",
                        "description": "FieldsV1 holds the first JSON version format as described in the \"FieldsV1\" type."
                    },
                    "manager": {
                        "type": "string",
                        "description": "Manager is an identifier of the workflow managing these fields."
                    },
                    "operation": {
                        "type": "string",
                        "description": "Operation is the type of operation which lead to this ManagedFieldsEntry being created. The only valid values for this field are 'Apply' and 'Update'."
                    },
                    "subresource": {
                        "type": "string",
                        "description": "Subresource is the name of the subresource used to update that object, or empty string if the object was updated through the main resource. The value of this field is used to distinguish between managers, even if they share the same name. For example, a status update will be distinct from a regular update using the same manager name. Note that the APIVersion field is not related to the Subresource field and it always corresponds to the version of the main resource."
                    },
                    "time": {
                        "type": "string",
                        "description": "Time is the timestamp of when the ManagedFields entry was added. The timestamp will also be updated if a field is added, the manager changes any of the owned fields value or removes a field. The timestamp does not update when a field is removed from the entry because another manager took it over."
                    }
                },
                "type": "io.k8s.apimachinery.pkg.apis.meta.v1.ManagedFieldsEntry",
                "description": "ManagedFieldsEntry is a workflow-id, a FieldSet and the group version of the resource that the fieldset applies to."
            },
            "io.k8s.apimachinery.pkg.apis.meta.v1.ObjectMeta": {
                "resourceFields": {
                    "annotations": {
                        "type": "map",
                        "subtype": "string",
                        "description": "Annotations is an unstructured key value map stored with a resource that may be set by external tools to store and retrieve arbitrary metadata. They are not queryable and should be preserved when modifying objects. More info: https://kubernetes.io/docs/concepts/overview/working-with-objects/annotations"
                    },
                    "creationTimestamp": {
                        "type": "string",
                        "description": "CreationTimestamp is a timestamp representing the server time when this object was created. It is not guaranteed to be set in happens-before order across separate operations. Clients may not set this value. It is represented in RFC3339 form and is in UTC.\n\nPopulated by the system. Read-only. Null for lists. More info: https://git.k8s.io/community/contributors/devel/sig-architecture/api-conventions.md#metadata"
                    },
                    "deletionGracePeriodSeconds": {
                        "type": "int",
                        "description": "Number of seconds allowed for this object to gracefully terminate before it will be removed from the system. Only set when deletionTimestamp is also set. May only be shortened. Read-only."
                    },
                    "deletionTimestamp": {
                        "type": "string",
                        "description": "DeletionTimestamp is RFC 3339 date and time at which this resource will be deleted. This field is set by the server when a graceful deletion is requested by the user, and is not directly settable by a client. The resource is expected to be deleted (no longer visible from resource lists, and not reachable by name) after the time in this field, once the finalizers list is empty. As long as the finalizers list contains items, deletion is blocked. Once the deletionTimestamp is set, this value may not be unset or be set further into the future, although it may be shortened or the resource may be deleted prior to this time. For example, a user may request that a pod is deleted in 30 seconds. The Kubelet will react by sending a graceful termination signal to the containers in the pod. After that 30 seconds, the Kubelet will send a hard termination signal (SIGKILL) to the container and after cleanup, remove the pod from the API. In the presence of network partitions, this object may still exist after this timestamp, until an administrator or automated process can determine the resource is fully terminated. If not set, graceful deletion of the object has not been requested.\n\nPopulated by the system when a graceful deletion is requested. Read-only. More info: https://git.k8s.io/community/contributors/devel/sig-architecture/api-conventions.md#metadata"
                    },
                    "finalizers": {
                        "type": "array",
                        "subtype": "string",
                        "description": "Must be empty before the object is deleted from the registry. Each entry is an identifier for the responsible component that will remove the entry from the list. If the deletionTimestamp of the object is non-nil, entries in this list can only be removed. Finalizers may be processed and removed in any order.  Order is NOT enforced because it introduces significant risk of stuck finalizers. finalizers is a shared field, any actor with permission can reorder it. If the finalizer list is processed in order, then this can lead to a situation in which the component responsible for the first finalizer in the list is waiting for a signal (field value, external system, or other) produced by a component responsible for a finalizer later in the list, resulting in a deadlock. Without enforced ordering finalizers are free to order amongst themselves and are not vulnerable to ordering changes in the list."
                    },
                    "generateName": {
                        "type": "string",
                        "description": "GenerateName is an optional prefix, used by the server, to generate a unique name ONLY IF the Name field has not been provided. If this field is used, the name returned to the client will be different than the name passed. This value will also be combined with a unique suffix. The provided value has the same validation rules as the Name field, and may be truncated by the length of the suffix required to make the value unique on the server.\n\nIf this field is specified and the generated name exists, the server will return a 409.\n\nApplied only if Name is not specified. More info: https://git.k8s.io/community/contributors/devel/sig-architecture/api-conventions.md#idempotency"
                    },
                    "generation": {
                        "type": "int",
                        "description": "A sequence number representing a specific generation of the desired state. Populated by the system. Read-only."
                    },
                    "labels": {
                        "type": "map",
                        "subtype": "string",
                        "description": "Map of string keys and values that can be used to organize and categorize (scope and select) objects. May match selectors of replication controllers and services. More info: https://kubernetes.io/docs/concepts/overview/working-with-objects/labels"
                    },
                    "managedFields": {
                        "type": "array",
                        "subtype": "io.k8s.apimachinery.pkg.apis.meta.v1.ManagedFieldsEntry",
                        "description": "ManagedFields maps workflow-id and version to the set of fields that are managed by that workflow. This is mostly for internal housekeeping, and users typically shouldn't need to set or understand this field. A workflow can be the user's name, a controller's name, or the name of a specific apply path like \"ci-cd\". The set of fields is always in the version that the workflow used when modifying the object."
                    },
                    "name": {
                        "type": "string",
                        "description": "Name must be unique within a namespace. Is required when creating resources, although some resources may allow a client to request the generation of an appropriate name automatically. Name is primarily intended for creation idempotence and configuration definition. Cannot be updated. More info: https://kubernetes.io/docs/concepts/overview/working-with-objects/names#names"
                    },
                    "namespace": {
                        "type": "string",
                        "description": "Namespace defines the space within which each name must be unique. An empty namespace is equivalent to the \"default\" namespace, but \"default\" is the canonical representation. Not all objects are required to be scoped to a namespace - the value of this field for those objects will be empty.\n\nMust be a DNS_LABEL. Cannot be updated. More info: https://kubernetes.io/docs/concepts/overview/working-with-objects/namespaces"
                    },
                    "ownerReferences": {
                        "type": "array",
                        "subtype": "io.k8s.apimachinery.pkg.apis.meta.v1.OwnerReference",
                        "description": "List of objects depended by this object. If ALL objects in the list have been deleted, this object will be garbage collected. If this object is managed by a controller, then an entry in this list will point to this controller, with the controller field set to true. There cannot be more than one managing controller."
                    },
                    "resourceVersion": {
                        "type": "string",
                        "description": "An opaque value that represents the internal version of this object that can be used by clients to determine when objects have changed. May be used for optimistic concurrency, change detection, and the watch operation on a resource or set of resources. Clients must treat these values as opaque and passed unmodified back to the server. They may only be valid for a particular resource or set of resources.\n\nPopulated by the system. Read-only. Value must be treated as opaque by clients and . More info: https://git.k8s.io/community/contributors/devel/sig-architecture/api-conventions.md#concurrency-control-and-consistency"
                    },
                    "selfLink": {
                        "type": "string",
                        "description": "Deprecated: selfLink is a legacy read-only field that is no longer populated by the system."
                    },
                    "uid": {
                        "type": "string",
                        "description": "UID is the unique in time and space value for this object. It is typically generated by the server on successful creation of a resource and is not allowed to change on PUT operations.\n\nPopulated by the system. Read-only. More info: https://kubernetes.io/docs/concepts/overview/working-with-objects/names#uids"
                    }
                },
                "type": "io.k8s.apimachinery.pkg.apis.meta.v1.ObjectMeta",
                "description": "ObjectMeta is metadata that all persisted resources must have, which includes all objects users must create."
            },
            "io.k8s.apimachinery.pkg.apis.meta.v1.OwnerReference": {
                "resourceFields": {
                    "apiVersion": {
                        "type": "string",
                        "description": "API version of the referent.",
                        "required": true
                    },
                    "blockOwnerDeletion": {
                        "type": "boolean",
                        "description": "If true, AND if the owner has the \"foregroundDeletion\" finalizer, then the owner cannot be deleted from the key-value store until this reference is removed. See https://kubernetes.io/docs/concepts/architecture/garbage-collection/#foreground-deletion for how the garbage collector interacts with this field and enforces the foreground deletion. Defaults to false. To set this field, a user needs \"delete\" permission of the owner, otherwise 422 (Unprocessable Entity) will be returned."
                    },
                    "controller": {
                        "type": "boolean",
                        "description": "If true, this reference points to the managing controller."
                    },
                    "kind": {
                        "type": "string",
                        "description": "Kind of the referent. More info: https://git.k8s.io/community/contributors/devel/sig-architecture/api-conventions.md#types-kinds",
                        "required": true
                    },
                    "name": {
                        "type": "string",
                        "description": "Name of the referent. More info: https://kubernetes.io/docs/concepts/overview/working-with-objects/names#names",
                        "required": true
                    },
                    "uid": {
                        "type": "string",
                        "description": "UID of the referent. More info: https://kubernetes.io/docs/concepts/overview/working-with-objects/names#uids",
                        "required": true
                    }
                },
                "type": "io.k8s.apimachinery.pkg.apis.meta.v1.OwnerReference",
                "description": "OwnerReference contains enough information to let you identify an owning object. An owning object must be in the same namespace as the dependent, or be cluster-scoped, so there is no namespace field."
            }
        }
    }
}

@richard-cox you might have a better idea on what's going on here

yonasberhe23 commented 3 months ago

unit tests are sufficient. I also tested using the above repro stesp and no longer see the issue. moving to done