Malfunctioning of comment using `#` when creating GitRepo

[mmartin24]

Setup

• Rancher version: v2.9-03e149351b6877d02ffe6f32be8b896708132f08-head (it also happens in 2.8.4, 2-8-head)
• Rancher UI Extensions:
• Browser type & version: Brave v1.66.118

Describe the bug Several issues here:

1. While creating a git repo after clicking on 'Edit YAML', if an user tries to comment a line prepending a # before the text it won't if this one is somehow indented. You have to prepend the hash exactly before the text without space
2. If you uncomment an already commented text and you try to comment back exactly in the same point you can't. It must be spaced in order to achieve it.

I will illustrate these 2 in a video

To Reproduce

• Deploy Rancher 2.8-head or 2.9-head(possibly also in 2.7)
• Go to Continuous Delivery > Git Repos > fleet-local > Add Repository
• Click on Edit YAML

Issue 1:

• Try adding a # at the very beginning of text repo

Issue 2:

• Now uncomment one of commented texts, for example revision: string
• Try to place a # at the beginning of the line

Result Issue 1: Observe is not possible Issue 2: Observe is not possible and that one must add a space

Expected Result Issue 1: I should be able to add a # at the beginning of the line regardless of indentation Issue 2: I shold be able to comment adding the # in the same place it was shown at the beginning.

Screenshots

Screencast from 13-06-24 17:11:40.webm

Additional context

[richard-cox]

Linking to https://github.com/rancher/dashboard/issues/11020

[richard-cox]

I could still reproduce this in v2.9-a84c3a2f, which contains the fix for both #11020 and #11225.

It seems this is an issue with the editor. Lines cannot start with #, but char can be inserted at other places in the line. Adding one after the first and before text will correctly comment out the line

[gaktive]

Holding off on a backport until we know what the solution is. The fact that this involves the YAML editor does put pause of what we can do based on past experiences.