search

rancher / dashboard

The Rancher UI
https://rancher.com
Apache License 2.0
441 stars 243 forks source link

Deprecate Weave support kubernetes versions >=1.30.0 #11322

Open Sahota1225 opened 2 weeks ago

Sahota1225 commented 2 weeks ago

Weave was deprecated for k8s >=v1.27 (ref https://github.com/rancher/rancher/issues/42730) and the support for this needs to be removed now for k8s >=1.30.

User should not be able to select weave as a CNI for k8s >=1.30 in the UI. earlier issue which was created for deprecation warning: https://github.com/rancher/dashboard/issues/9556 rke should throw an error if cluster >=1.30 is provisioned with weave. docs needs to be updated accordingly to notify users for weave deprecation.

richard-cox commented 2 weeks ago

Needs confirming, but given https://github.com/rancher/dashboard/issues/9556#issuecomment-1699412649 once the endpoints are updated the ui will no longer show the options. We also need to confirm what happens when bumping the kube version to 1.30 on an existing cluster with weave enabled

Edit: If this is only applicable to RKE1 then please ignore the comment regarding endpoints above.

gaktive commented 2 weeks ago

Related PR from our prior efforts: https://github.com/rancher/ui/pull/5062

nwmac commented 2 weeks ago

@richard-cox The list of options is hard-coded in the UI - see: https://github.com/rancher/ui/blob/master/lib/shared/addon/components/form-network-config/component.js#L31 - so we'd need to add some logic in there to not show the option when the k8s version >= 1.30

The deprecation banner appears correctly when the version is >= 1.27, so we can keep that in.

Only tricky thing is if the user has a cluster < 1.30 with weave networking and they go to edit, we'd need something to tell them to change it, or we'd need to change it to the default option and show the banner - this complicates this considerably.

FYI @gaktive - this is probably a day of work if all goes well, but adds more manual testing for QA.

nwmac commented 2 weeks ago

@Sahota1225 Is this just RKE1? i.e. NOT RKE2

gaktive commented 2 weeks ago

We need to know what the behaviour should be so @Sahota1225 will keep UI in the loop as she talks with @kinarashah about what to do. This is a late breaking change that is needed for 2.9.0 so we may have to delay things.

gaktive commented 2 weeks ago

Update from Hostbusters: this is no longer a release blocker. A release note will be added to advise Weave users that the message is misleading but RKE creation will not go through as a validation warning will arise based on existing logic.

We can look at this for 2.10.0 with a possible backport for 2.9.x to make this experience clearer.