rancher / dashboard

The Rancher UI
https://rancher.com
Apache License 2.0
461 stars 261 forks source link

Add "v27.0.x", "v27.1.x", and "v27.2.x" options for "Docker Install URL" #11523

Closed snasovich closed 1 month ago

snasovich commented 3 months ago

Is your feature request related to a problem? Please describe. As part of https://github.com/rancher/rancher/issues/46326 we're adding support for Docker 27.0.x and 27.1.x.

Edited after creation to also include v27.2.x as part of https://github.com/rancher/rancher/pull/47290.

Describe the solution you'd like UI dropdowns that allow picking "Docker Install URL" (e.g. on Node Template details page - not sure where else it may be referenced) should have the following new items available:

Note: Handling of default option (and addition of " (Recommended)" text) is handled via engine-install-url setting on backend that will be updated as part of https://github.com/rancher/rancher/issues/46326 and should be validated on that issue.

Describe alternatives you've considered Note "Docker Install URL" is editable and doesn't limit users to only the choices available, so they can specify other URLs manually as well before this enhancement is done.

Additional Information

See https://github.com/rancher/dashboard/issues/10996 on how it was handled last time for Docker 26.1

Testing

To test, go to create a Digital Ocean cluster, click on 'Add Node Template', select a credential and click Next. Expand 'Engine Options' and verify that the new Docker Install URLs appear correctly, e.g. image

richard-cox commented 3 months ago

/backport v2.9.next1

rancher-max commented 1 month ago

It looks like there was some scope adjustment here for 2.10, and we are also going to be including docker v27.2.x now.

Ref:

rancher-max commented 1 month ago

Validated using rancher head build

Rancher Version Info

image

Validations

1. Default is correctly pointing to v27.2.x and the url it is pointing to is correct

image

2. URL for v27.1.x is correct

image

3. URL for v27.0.x is correct

image