search

rancher / dashboard

The Rancher UI
https://rancher.com
Apache License 2.0
455 stars 257 forks source link

[2.8] [EKS] No way to revert if an invalid public endpoint is added to the cluster #11552

Open valaparthvi opened 4 months ago

valaparthvi commented 4 months ago

Steps to reproduce:

  1. Create an EKS cluster via the Rancher (2.8-head(827dba1)) dashboard.
  2. Once the cluster is Active, modify it and add an invalid public endpoint,invalid-endpoint for e.g.
  3. The cluster goes into Updating state and errors out with: Controller.FailureMessage{ClusterName:"pvala-eks-invalid-values-test", Message_:"The following CIDRs are invalid in publicAccessCidrs: [invalid-endpoint]", NodegroupName:""}.
  4. Edit the cluster to remove the invalid endpoint and save.
  5. There is no change, the cluster still errors out.

There is no way to revert even after multiple tries to remove the invalid ep. The only way to fix the error is delete the cluster, which is not a solution.

The change is not transmitted to the console, so the cluster remains clean there.

image

Screencast from 05-31-2024 12:28:06 PM.webm

yiannistri commented 2 months ago

It seems that the issue here is that the change from the UI (removing the invalid endpoint) is not being persisted and spec.eksConfig.publicAccessSources remains unchanged causing the controller to error out.

I've also checked the PUT request payload and it seems to include the nodeGroups field but not publicAccessSources which would explain above behaviour.

yiannistri commented 2 months ago

Moved this back to the backlog although based on my findings, I'm not sure whether this should stay on the CAPI & Hosted providers backlog cc @kkaempf

kkaempf commented 2 months ago

I'm not sure whether this should stay on the CAPI & Hosted providers backlog

What would you propose ?

mjura commented 2 months ago

What would you propose ?

It seems that it is UI issue, please reassign it

valaparthvi commented 2 months ago

I tested again on Rancher (v2.8-51052a73adcd6ea40cedcefbedc25e707cdb2f25-head), Dashboard(release-2.8 a38998e). It is slightly flaky, I could not reproduce it the first time, but then when I tried to edit it removing it via API, it was removed successfully, so it is a UI issue. I will close this one and reopen one in rancher/dashboard.

kkaempf commented 2 months ago

@valaparthvi I can also transfer this issue to dashboard 😉

valaparthvi commented 2 months ago

@kkaempf Oh you're right. I did not look for that option. I can do that :)