codyrancher
commented
2 months ago I'd definitely like to see us standardize on a resolution.
I do want to note that we have at least one special case around tables and bulk actions when the windows is small enough. Here's a video demonstrating what I mean.
https://github.com/user-attachments/assets/7d49e3b1-b1c2-48f5-a32d-3b4a50c0841c
We should ideally define a standard screen resolution for all e2e tests to be executed, which should be the minimal resolution in which all the UI components are fully displayed. Suggestion: (width 1000 x height 660), as in https://github.com/rancherlabs/corral-packages/pull/38
The purpose of this issue is to investigate if we can run the following tests with the same screen resolution
I see the following tests that are being executed under custom resolutions, that is, that have specific calls to
cy.viewport():e2e/tests/pages/charts/monitoring-istio.spec.ts(1280, 720)/e2e/tests/pages/manager/cluster-provisioning-amazon-ec2-rke1.spec.ts(1440, 900)e2e/tests/pages/manager/cluster-provisioning-azure-rke1.spec.ts(1440, 900)e2e/tests/pages/manager/node-drivers.spec.ts(1440, 900)e2e/tests/pages/manager/node-templates.spec.ts(1440, 900)e2e/tests/pages/manager/pod-security-admissions.spec.ts(1380, 720)e2e/tests/pages/manager/pod-security-policy-templates.spec.ts(1380, 720)e2e/tests/pages/manager/rke-templates.spec.ts(1440, 900)For the rke1 related tests, like
cluster-provisioning-amazon-ec2-rke1.spec.ts,cluster-provisioning-azure-rke1.spec.ts,rke-templates.spec.tsthere's no need to address these changes, but my question is if there's a reason why the non-rke1 related test files are using a custom resolution.