rancher / dashboard

The Rancher UI
https://rancher.com
Apache License 2.0
456 stars 258 forks source link

[BUG] [v2.9.1] Can not upgrade downstream cluster to new RKE template revision #11874

Open phoenix-bjoern opened 1 month ago

phoenix-bjoern commented 1 month ago

SURE-9052

This issue was initially reported in https://github.com/rancher/rancher/issues/46967, but maybe is only a bug in the UI.

Rancher Server Setup

Information about the Cluster

User Information

Describe the bug Rancher has been upgraded from v2.8.4 to v2.9.1. A new RKE1 template revision has been cloned to prepare a K8S upgrade from v1.28.9 to v1.29.7. When editing an existing downstream cluster the new RKE1 template revision can not be saved.

At first the UI looks normal: Bildschirmfoto 2024-09-05 um 13 00 03

However, when a RKE template is selected... Bildschirmfoto 2024-09-05 um 13 00 27

...form elements and the save button disappear:

Bildschirmfoto 2024-09-05 um 13 01 37

It is not possible to save the changes. Hence it is not possible to upgrade a cluster which is based on the RKE1 template.

To Reproduce

  1. Create a new revision of a RKE1 template.
  2. Edit an existing downstream cluster.
  3. Select the new RKE1 template revision.

Result The form elements for "Cluster Options" disappear, also the "Save" button.

Expected Result The form updates the information in the "Cluster Options" section according to the RKE1 template settings and the new revision can be saved to initiate the downstream cluster upgrade.

phoenix-bjoern commented 3 weeks ago

Can still reproduce the issue with Rancher v2.9.2.

jiaqiluo commented 3 weeks ago

I was able to reproduce this issue on a Rancher v2.9.1 Docker installation.

Steps:

  1. Create an RKE cluster template, leaving all values as default except setting the Kubernetes version to a non-latest version, such as 1.28.x.
  2. Create a custom RKE cluster using this template. Register a single node with all roles to the cluster and wait for the cluster to become active.
  3. Create a new revision of the same cluster template, only changing the Kubernetes version to a higher version like 1.29.
  4. Attempt to upgrade the existing custom cluster using the new template revision.

Results:

This issue does not occur on Rancher v2.8.8.

I would like to request the UI team to investigate this issue on the UI side.

cc @gaktive

phoenix-bjoern commented 2 weeks ago

@gaktive Due to this bug it is not possible to update downstream RKE1 clusters. Therefore security of the managed clusters is also affected. Please reconsider the priority of this issue and the release schedule. Thanks!

gaktive commented 2 weeks ago

Could be tied to the recent Ember upgrade. Need to have an engineer repro this.

ManuelSimon commented 2 weeks ago

Workaround here:

We will be using the Rancher v3 API. It has its own user interface accessible from a web browser. Workaround steps:

phoenix-bjoern commented 2 weeks ago

@ManuelSimon Thank for the detailed description! I can confirm that this workaround works and the downstream clusters can actually be updated via API.