search

rancher / dashboard

The Rancher UI
https://rancher.com
Apache License 2.0
463 stars 262 forks source link

[2.9] [GKE] Default network is not 'default' when provisioning the cluster #11895

Open valaparthvi opened 2 months ago

valaparthvi commented 2 months ago

Setup

Describe the bug

The dropdown lists networks alphabetically, so the network starting with a,b, or c and first in the list is selected by default, rather than 'default'.

To Reproduce

  1. On 2.9-head, open GKE create wizard and go to Networking section.
  2. Check the Network and Node Subnet.

Result My existing list contains a network called cpinjani-private which is selected by default. Expected Result

default network must be selected by default.

Screenshots

2.8 - image 2.9 - Screenshot from 2024-09-12 12-57-16

Additional context

This can also be misleading since the Networking section is collapsed by default.

valaparthvi commented 2 months ago

@richard-cox I am not sure which milestone to set here, should it be v2.10.0 with backport-candidate label?

richard-cox commented 2 months ago

@valaparthvi that's correct! is this a regression?

valaparthvi commented 2 months ago

@valaparthvi that's correct! is this a regression?

Yes, it is a regression.

mantis-toboggan-md commented 2 months ago

Just looked into this a bit, per google docs a 'default' vpc is not guaranteed to be present:

Projects can contain multiple VPC networks. Unless you create an organizational policy that prohibits it, new projects start with a default network (an auto mode VPC network) that has one subnetwork (subnet) in each region.

Whoever picks this up needs to account for this scenario.

gaktive commented 3 weeks ago

/backport v2.10.1