rancher / dashboard

The Rancher UI
https://rancher.com
Apache License 2.0
460 stars 261 forks source link

Forward port from Ember: Last imagePullPolicy should be remembered and used as future default #3538

Open dkeightley opened 3 years ago

dkeightley commented 3 years ago

What kind of request is this (question/bug/enhancement/feature request): enhancement

Steps to reproduce (least amount of steps as possible):

Result:

Pods starting from the workload always perform a registry manifest request to verify the image when creating containers.

Other details that may be helpful:

Creating this as discussion, with the recent rate limiting this can account for an unexpected portion of requests to registries when there is churn, backoff/retries, or high number of replicas started from workloads created in the UI. The k8s API default is ifNotPresent.

stale[bot] commented 3 years ago

This repository uses a bot to automatically label issues which have not had any activity (commit/comment/label) for 60 days. This helps us manage the community issues better. If the issue is still relevant, please add a comment to the issue so the bot can remove the label and we know it is still valid. If it is no longer relevant (or possibly fixed in the latest release), the bot will automatically close the issue in 14 days. Thank you for your contributions.

dkeightley commented 3 years ago

This is the case still in v2.5.8 Cluster Manager/Explorer, reopening in case this deserves consideration.

vincent99 commented 3 years ago

UI users tend to put in no tag/latest more than people writing YAML and we don't think "I dunno, whatever you've got lying around" is a very good default for them.

Actually, Manager saves a preference for the last pull policy value you used and used that as the default for next time, so the basis of this issue was never true...

But Explorer does not have that behavior, so it has become true for the new Ui. Moving to dashboard for future enhancement.