search

rancher / dashboard

The Rancher UI
https://rancher.com
Apache License 2.0
450 stars 254 forks source link

Cluster Management Clusters list shows incorrect 'Machines' value for new RKE1 cluster #4712

Open richard-cox opened 2 years ago

richard-cox commented 2 years ago

Describe the bug Cluster Management Clusters list shows 'Machines' ready for a RKE1 cluster that's just been created (and is still coming up). Upon being returned to the list it's first state is 'Ready'

To Reproduce

  1. Create an RKE1 cluster (user taken to the Cluster Management Cluster list)

Result See screenshot, Machines state shows initial state of 'Ready'

Expected Result Not quite sure, think this should match the 'Registering' node state seen in the second screenshot?

Screenshots image

image

Additional context Note - the visibility of the Nodes tab in the cluster detail page requires fix from https://github.com/rancher/dashboard/issues/4711

richard-cox commented 2 years ago

I had a super quick look in to this, it could be that the row isn't dynamically updating on change (had to nav & return to see it successfully 'deployed'). The column formatter is components/formatter/MachineSummaryGraph.vue .. which works with stateParts from models/provisioning.cattle.io.cluster.js .. which gets a pool state ('ready' / 'pending' / etc) from models/management.cattle.io.nodepool.js

Update: It looks like the state of the node pool is determined via the number of nodes within it (required vs actual) rather than the state of the nodes themselves.

I'm not sure of the correct solution here, should we represent individual node state in the clusters list? The title of the column 'Machines' is pretty overloaded, contents shows...